Changeset 223632 in webkit

Timestamp:

Oct 18, 2017 3:01:49 PM (7 years ago)

Author:

dino@apple.com

Message:

Make failing WebGL tests produce debug output
​https://bugs.webkit.org/show_bug.cgi?id=178421

Reviewed by Jon Lee.

If a WebGL conformance test fails, we just get the word "FAIL". Instead,
have it log the actual output of the test, so we can see what happens
on bots.

Drive-by fix where I noticed a test file was missing, that causes
two tests to timeout. They may still timeout, but now because they
take a long time to run rather than they have a JS error.

• platform/mac/TestExpectations:
• webgl/1.0.2/resources/webgl_test_files/conformance/resources/iterable-test.js: Added.
• webgl/1.0.2/resources/webkit-webgl-test-harness.js:

(window.webglTestHarness.notifyFinished):

• webgl/resources/webkit-webgl-test-harness.js:

(window.webglTestHarness.notifyFinished):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)
• webgl/1.0.2/resources/webgl_test_files/conformance/resources/iterable-test.js (added)
• webgl/1.0.2/resources/webkit-webgl-test-harness.js (modified) (1 diff)
• webgl/resources/webkit-webgl-test-harness.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-17  Dean Jackson  <dino@apple.com>
+
+        Make failing WebGL tests produce debug output
+        https://bugs.webkit.org/show_bug.cgi?id=178421
+
+        Reviewed by Jon Lee.
+
+        If a WebGL conformance test fails, we just get the word "FAIL". Instead,
+        have it log the actual output of the test, so we can see what happens
+        on bots.
+
+        Drive-by fix where I noticed a test file was missing, that causes
+        two tests to timeout. They may still timeout, but now because they
+        take a long time to run rather than they have a JS error.
+
+        * platform/mac/TestExpectations:
+        * webgl/1.0.2/resources/webgl_test_files/conformance/resources/iterable-test.js: Added.
+        * webgl/1.0.2/resources/webkit-webgl-test-harness.js:
+        (window.webglTestHarness.notifyFinished):
+        * webgl/resources/webkit-webgl-test-harness.js:
+        (window.webglTestHarness.notifyFinished):
+
 2017-10-18  Eric Carlson  <eric.carlson@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -396 +396 @@
 # Unexpected WebGL Conformance tests that need to be fixed
 # These tests pass when run through webgl-conformance-tests.html but not when just opened via a browser (or via run-webkit-tests)
-webgl/1.0.2/conformance/context/context-creation-and-destruction.html [ Failure Timeout ]
-webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Pass Failure Timeout ]
+webgl/1.0.2/conformance/context/context-creation-and-destruction.html [ Pass Timeout ]
+webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Pass Timeout ]
 http/tests/webgl/1.0.2/origin-clean-conformance.html [ Skip ]
 

trunk/LayoutTests/webgl/1.0.2/resources/webkit-webgl-test-harness.js

@@ -40 +40 @@
     notifyFinished: function(url) {
       var iframe = document.getElementById("iframe");
-      iframe.innerHTML = "";
       if (numFailures > 0) {
         log("FAIL", "red");
       } else {
         log("PASS", "green");
+        iframe.innerHTML = "";
       }
 

trunk/LayoutTests/webgl/resources/webkit-webgl-test-harness.js

@@ -40 +40 @@
     notifyFinished: function(url) {
       var iframe = document.getElementById("iframe");
-      iframe.innerHTML = "";
       if (numFailures > 0) {
         log("FAIL", "red");
       } else {
         log("PASS", "green");
+        iframe.innerHTML = "";
       }