Changeset 223719 in webkit

Timestamp:

Oct 19, 2017 3:47:49 PM (7 years ago)

Author:

aestes@apple.com

Message:

[iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
​https://bugs.webkit.org/show_bug.cgi?id=178181
<rdar://problem/33660282>

Reviewed by Dan Bernstein.

Source/WebKit:

• Configurations/BaseTarget.xcconfig:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):

• WebKit.xcodeproj/project.pbxproj:

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::databaseProcessName):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Configurations/BaseTarget.xcconfig (modified) (1 diff)
• Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-10-19  Andy Estes  <aestes@apple.com>
+
+        [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
+        https://bugs.webkit.org/show_bug.cgi?id=178181
+        <rdar://problem/33660282>
+
+        Reviewed by Dan Bernstein.
+
+        * Configurations/BaseTarget.xcconfig:
+        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+        (WebKit::serviceName):
+        * WebKit.xcodeproj/project.pbxproj:
+
 2017-10-19  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Configurations/BaseTarget.xcconfig

@@ -107 +107 @@
 WK_CORE_PREDICTION_DEFINES_YES = HAVE_CORE_PREDICTION;
 
-WK_STORAGE_SERVICE_PRODUCT_NAME = com.apple.WebKit.Databases;
-WK_STORAGE_SERVICE_PRODUCT_NAME[sdk=macosx*] = com.apple.WebKit.Storage;
-WK_STORAGE_SERVICE_PRODUCT_NAME[sdk=*simulator*] = com.apple.WebKit.Storage;
+WK_STORAGE_SERVICE_PRODUCT_NAME = $(WK_STORAGE_SERVICE_PRODUCT_NAME_$(WK_USE_LEGACY_STORAGE_SERVICE_NAME));
+WK_STORAGE_SERVICE_PRODUCT_NAME_ = $(WK_STORAGE_SERVICE_PRODUCT_NAME_NO);
+WK_STORAGE_SERVICE_PRODUCT_NAME_NO = com.apple.WebKit.Storage;
+WK_STORAGE_SERVICE_PRODUCT_NAME_YES = com.apple.WebKit.Databases;
+
+WK_USE_LEGACY_STORAGE_SERVICE_NAME[sdk=iphoneos11*] = $(WK_USE_LEGACY_STORAGE_SERVICE_NAME_11$(IPHONEOS_DEPLOYMENT_TARGET:suffix:identifier));
+WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_0 = YES;
+WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_1 = YES;
+WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_2 = YES;

trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm

@@ -57 +57 @@
         return "com.apple.WebKit.Networking";
     case ProcessLauncher::ProcessType::Storage:
-#if PLATFORM(MAC) || PLATFORM(IOS_SIMULATOR)
+#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !PLATFORM(IOS_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 110300
+        return "com.apple.WebKit.Databases";
+#else
         return "com.apple.WebKit.Storage";
-#else
-        return "com.apple.WebKit.Databases";
 #endif
 #if ENABLE(NETSCAPE_PLUGIN_API)
@@ -70 +70 @@
     }
 }
-    
+
 static bool shouldLeakBoost(const ProcessLauncher::LaunchOptions& launchOptions)
 {

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-19  Andy Estes  <aestes@apple.com>
+
+        [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
+        https://bugs.webkit.org/show_bug.cgi?id=178181
+        <rdar://problem/33660282>
+
+        Reviewed by Dan Bernstein.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::databaseProcessName):
+
 2017-10-19  Saam Barati  <sbarati@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -909 +909 @@
     // FIXME: Find a way to not hardcode the process name.
 #if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
+#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && __IPHONE_OS_VERSION_MIN_REQUIRED < 110300
     return "com.apple.WebKit.Databases";
+#else
+    return "com.apple.WebKit.Storage";
+#endif
 #elif PLATFORM(COCOA)
     return "com.apple.WebKit.Storage.Development";