Changeset 223741 in webkit

Timestamp:

Oct 19, 2017 8:08:26 PM (6 years ago)

Author:

sbarati@apple.com

Message:

Runtime disable gigacage on iOS because it broke WasmBench
​https://bugs.webkit.org/show_bug.cgi?id=178556

Reviewed by Keith Miller.

• bmalloc/Gigacage.cpp:

(Gigacage::shouldBeEnabled):

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Gigacage.cpp (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2017-10-19  Saam Barati  <sbarati@apple.com>
+
+        Runtime disable gigacage on iOS because it broke WasmBench
+        https://bugs.webkit.org/show_bug.cgi?id=178556
+
+        Reviewed by Keith Miller.
+
+        * bmalloc/Gigacage.cpp:
+        (Gigacage::shouldBeEnabled):
+
 2017-10-17  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/bmalloc/bmalloc/Gigacage.cpp

@@ -241 +241 @@
 {
     static std::once_flag onceFlag;
-    static bool cached;
+    static bool cached = false;
     std::call_once(
         onceFlag,
         [] {
+#if BCPU(ARM64)
+            // FIXME: Make WasmBench run with gigacage on iOS and re-enable on ARM64:
+            // https://bugs.webkit.org/show_bug.cgi?id=178557
+            return;
+#endif
             bool result = GIGACAGE_ENABLED && !PerProcess<Environment>::get()->isDebugHeapEnabled();
             if (!result)