Changeset 223867 in webkit

Timestamp:

Oct 23, 2017 5:35:42 PM (6 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
​https://bugs.webkit.org/show_bug.cgi?id=178638

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
which displayed inline swatches. Display inline swatches only after blur event on the property value.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SpreadsheetStyleProperty.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-10-23  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
+        https://bugs.webkit.org/show_bug.cgi?id=178638
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
+        Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
+        which displayed inline swatches. Display inline swatches only after blur event on the property value.
+
 2017-10-23  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js

@@ -236 +236 @@
         if (textField.value.trim() === "")
             this._remove();
-        else
+        else if (textField === this._valueTextField)
             this._renderValue(this._valueElement.textContent);
     }