Changeset 223895 in webkit

Timestamp:

Oct 24, 2017 10:24:40 AM (7 years ago)

Author:

rniwa@webkit.org

Message:

SizesAttributeParser::SizesAttributeParser triggers layout
​https://bugs.webkit.org/show_bug.cgi?id=178712

Reviewed by Antti Koivisto.

Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.

The test had been marked as timing out since r191379 and changed to failing expectation in r199225
as the test result's error message changes from run to run.

Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html

had been marked failing since r199225, prior to which it was marked as timeout in r191379.
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
is now marked as flaky.

• css/parser/SizesAttributeParser.cpp:

(WebCore::SizesAttributeParser::SizesAttributeParser):

Location:

trunk

Files:

• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/parser/SizesAttributeParser.cpp (modified) (1 diff)

trunk/LayoutTests/TestExpectations

@@ -657 +657 @@
 imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html [ Failure Timeout ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html [ Failure ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html [ Pass Failure ]
 
 # Imported Mozilla SVG tests

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        SizesAttributeParser::SizesAttributeParser triggers layout
+        https://bugs.webkit.org/show_bug.cgi?id=178712
+
+        Reviewed by Antti Koivisto.
+
+        Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.
+
+        The test had been marked as timing out since r191379 and changed to failing expectation in r199225
+        as the test result's error message changes from run to run.
+
+        Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html
+                        had been marked failing since r199225, prior to which it was marked as timeout in r191379.
+                        imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
+                        is now marked as flaky.
+
+        * css/parser/SizesAttributeParser.cpp:
+        (WebCore::SizesAttributeParser::SizesAttributeParser):
+
 2017-10-24  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WebCore/css/parser/SizesAttributeParser.cpp

@@ -74 +74 @@
     , m_lengthWasSet(false)
 {
-    // Ensure iframes have correct view size.
-    if (m_document.ownerElement())
-        m_document.ownerElement()->document().updateLayoutIgnorePendingStylesheets();
-
     m_isValid = parse(CSSTokenizer(attribute).tokenRange());
 }