Changeset 223902 in webkit

Timestamp:

Oct 24, 2017 11:40:17 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[MediaFoundation] Videos are always autoplaying for local files
​https://bugs.webkit.org/show_bug.cgi?id=178693

Patch by Doug Massay.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2017-10-24
Reviewed by Alex Christensen.

r199114 fixes autoplay issue only if starting session invokes
buffering stage. However when local files are played, onBufferingStarted
and onBufferingStopped are not called, and video is not paused.

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::onSessionStarted):

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (modified) (2 diffs)
• platform/graphics/win/MediaPlayerPrivateMediaFoundation.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-24  Konstantin Tokarev  <annulen@yandex.ru>
+
+        [MediaFoundation] Videos are always autoplaying for local files
+        https://bugs.webkit.org/show_bug.cgi?id=178693
+
+        Patch by Doug Massay.
+        Reviewed by Alex Christensen.
+
+        r199114 fixes autoplay issue only if starting session invokes
+        buffering stage. However when local files are played, onBufferingStarted
+        and onBufferingStopped are not called, and video is not paused.
+
+        * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+        (WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
+        (WebCore::MediaPlayerPrivateMediaFoundation::onSessionStarted):
+        * platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
+
 2017-10-24  Matt Lewis  <jlewis3@apple.com>
 

trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp

@@ -536 +536 @@
     }
 
+    case MESessionStarted: {
+        callOnMainThread([weakPtr = m_weakPtrFactory.createWeakPtr(*this)] {
+            if (!weakPtr)
+                return;
+            weakPtr->onSessionStarted();
+        });
+        break;
+    }
+
     case MEBufferingStarted: {
         callOnMainThread([weakPtr = m_weakPtrFactory.createWeakPtr(*this)] {
@@ -918 +927 @@
 
 void MediaPlayerPrivateMediaFoundation::onBufferingStopped()
+{
+    updateReadyState();
+}
+
+void MediaPlayerPrivateMediaFoundation::onSessionStarted()
 {
     updateReadyState();

trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h

@@ -152 +152 @@
     void onBufferingStarted();
     void onBufferingStopped();
+    void onSessionStarted();
     void onSessionEnded();