Changeset 223906 in webkit

Timestamp:

Oct 24, 2017 11:52:47 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

HTMLMediaElement should iterate HTMLTrackElements consistently.
​https://bugs.webkit.org/show_bug.cgi?id=178423
rdar://problem/35044967

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-10-24
Reviewed by Eric Carlson.

No new tests because no expected behavior change.

HTMLMediaElement iterates HTMLTrackElements as children in every place but one, where it iterates them
as descendants. It should always iterate them as children.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::finishParsingChildren):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-24  Jeremy Jones  <jeremyj@apple.com>
+
+        HTMLMediaElement should iterate HTMLTrackElements consistently.
+        https://bugs.webkit.org/show_bug.cgi?id=178423
+        rdar://problem/35044967
+
+        Reviewed by Eric Carlson.
+
+        No new tests because no expected behavior change.
+
+        HTMLMediaElement iterates HTMLTrackElements as children in every place but one, where it iterates them
+        as descendants. It should always iterate them as children.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::finishParsingChildren):
+
 2017-10-24  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -841 +841 @@
 
 #if ENABLE(VIDEO_TRACK)
-    if (descendantsOfType<HTMLTrackElement>(*this).first())
+    if (childrenOfType<HTMLTrackElement>(*this).first())
         scheduleDelayedAction(ConfigureTextTracks);
 #endif