Changeset 223930 in webkit


Ignore:
Timestamp:
Oct 24, 2017 3:05:30 PM (7 years ago)
Author:
aestes@apple.com
Message:

[WebIDL] Support the ExportMacro attribute for dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=178752

Reviewed by Sam Weinig.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryHeaderContent):

  • bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
  • bindings/scripts/test/TestStandaloneDictionary.idl:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r223929 r223930  
     12017-10-24  Andy Estes  <aestes@apple.com>
     2
     3        [WebIDL] Support the ExportMacro attribute for dictionaries
     4        https://bugs.webkit.org/show_bug.cgi?id=178752
     5
     6        Reviewed by Sam Weinig.
     7
     8        * bindings/scripts/CodeGeneratorJS.pm:
     9        (GenerateDictionaryHeaderContent):
     10        * bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
     11        * bindings/scripts/test/TestStandaloneDictionary.idl:
     12
    1132017-10-24  Eric Carlson  <eric.carlson@apple.com>
    214

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r223780 r223930  
    22232223    $headerIncludes{"JSDOMConvertDictionary.h"} = 1;
    22242224
     2225    my $exportMacro = GetExportMacroForJSClass($dictionary);
     2226
    22252227    my $result = "";
    22262228    $result .= "#if ${conditionalString}\n\n" if $conditionalString;
    2227     $result .= "template<> ${className} convertDictionary<${className}>(JSC::ExecState&, JSC::JSValue);\n\n";
     2229    $result .= "template<> ${exportMacro}${className} convertDictionary<${className}>(JSC::ExecState&, JSC::JSValue);\n\n";
    22282230
    22292231    if ($dictionary->extendedAttributes->{JSGenerateToJSObject}) {
    2230         $result .= "JSC::JSObject* convertDictionaryToJS(JSC::ExecState&, JSDOMGlobalObject&, const ${className}&);\n\n";
     2232        $result .= "${exportMacro}JSC::JSObject* convertDictionaryToJS(JSC::ExecState&, JSDOMGlobalObject&, const ${className}&);\n\n";
    22312233    }
    22322234

  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h

    r221598 r223930  
    2929namespace WebCore {
    3030
    31 template<> DictionaryImplName convertDictionary<DictionaryImplName>(JSC::ExecState&, JSC::JSValue);
     31template<> WEBCORE_EXPORT DictionaryImplName convertDictionary<DictionaryImplName>(JSC::ExecState&, JSC::JSValue);
    3232
    3333String convertEnumerationToString(TestStandaloneDictionary::EnumInStandaloneDictionaryFile);

  • trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl

    r207768 r223930  
    3232    ImplementedAs=DictionaryImplName,
    3333    Conditional=Condition1,
     34    ExportMacro=WEBCORE_EXPORT,
    3435] dictionary TestStandaloneDictionary {
    3536    boolean boolMember;
Note: See TracChangeset for help on using the changeset viewer.