Changeset 223949 in webkit
- Timestamp:
- Oct 24, 2017 11:26:58 PM (6 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r223947 r223949 1 2017-10-24 Alejandro G. Castro <alex@igalia.com> 2 3 Clean up gcc build warnings about reaching the end of a non void function for webrtc classes 4 https://bugs.webkit.org/show_bug.cgi?id=178721 5 6 Reviewed by Youenn Fablet. 7 8 Assert when we reach those situations and return some value after that to avoid warning. 9 10 No new tests, this is a clean up. 11 12 * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: 13 (WebCore::sessionDescriptionType): 14 (WebCore::signalingState): 15 (WebCore::toRTCIceConnectionState): 16 * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: 17 (WebCore::bundlePolicyfromConfiguration): 18 (WebCore::iceTransportPolicyfromConfiguration): 19 1 20 2017-10-24 Ryosuke Niwa <rniwa@webkit.org> 2 21 -
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
r223476 r223949 94 94 return "rollback"; 95 95 } 96 97 ASSERT_NOT_REACHED(); 98 return ""; 96 99 } 97 100 … … 601 604 return RTCSignalingState::Stable; 602 605 } 606 607 ASSERT_NOT_REACHED(); 608 return RTCSignalingState::Stable; 603 609 } 604 610 … … 831 837 return RTCIceConnectionState::Closed; 832 838 case webrtc::PeerConnectionInterface::kIceConnectionMax: 833 ASSERT_NOT_REACHED(); 834 return RTCIceConnectionState::New; 835 } 839 break; 840 } 841 842 ASSERT_NOT_REACHED(); 843 return RTCIceConnectionState::New; 836 844 } 837 845 -
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
r223728 r223949 78 78 return webrtc::PeerConnectionInterface::kBundlePolicyBalanced; 79 79 } 80 81 ASSERT_NOT_REACHED(); 82 return webrtc::PeerConnectionInterface::kBundlePolicyMaxCompat; 80 83 } 81 84 … … 88 91 return webrtc::PeerConnectionInterface::kAll; 89 92 } 93 94 ASSERT_NOT_REACHED(); 95 return webrtc::PeerConnectionInterface::kNone; 90 96 } 91 97
Note: See TracChangeset
for help on using the changeset viewer.