Changeset 223960 in webkit

Timestamp:

Oct 25, 2017 10:39:47 AM (6 years ago)

Author:

jer.noble@apple.com

Message:

Autoplay muted videos still stop playback of other streaming apps in the background
​https://bugs.webkit.org/show_bug.cgi?id=177920

Reviewed by Eric Carlson.

When creating a new <video> or <audio> element, the global AudioSession can sometimes have
its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
source. This is because the constructor for the MediaElementSession is called before
m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.

We could move the MediaElementSession ivar to the very end of the header, so it's
initialized last, but that still leaves the possibility of the MediaElementSession et. all
calling into the HTMLMediaElement before it's subclass's constructors have a chance to
initialize their own ivars (much less their vtables). So instead, we'll create and set the
MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
HTMLAudioElement's create() factory methods.

• html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::finishInitialization):

• html/HTMLMediaElement.h:
• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLAudioElement.cpp (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (3 diffs)
• html/HTMLMediaElement.h (modified) (1 diff)
• html/HTMLVideoElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-25  Jer Noble  <jer.noble@apple.com>
+
+        Autoplay muted videos still stop playback of other streaming apps in the background
+        https://bugs.webkit.org/show_bug.cgi?id=177920
+
+        Reviewed by Eric Carlson.
+
+        When creating a new <video> or <audio> element, the global AudioSession can sometimes have
+        its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
+        source. This is because the constructor for the MediaElementSession is called before
+        m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
+        the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.
+
+        We could move the MediaElementSession ivar to the very end of the header, so it's
+        initialized last, but that still leaves the possibility of the MediaElementSession et. all
+        calling into the HTMLMediaElement before it's subclass's constructors have a chance to
+        initialize their own ivars (much less their vtables). So instead, we'll create and set the
+        MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
+        HTMLAudioElement's create() factory methods.
+
+        * html/HTMLAudioElement.cpp:
+        (WebCore::HTMLAudioElement::create):
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::HTMLMediaElement):
+        (WebCore::HTMLMediaElement::finishInitialization):
+        * html/HTMLMediaElement.h:
+        * html/HTMLVideoElement.cpp:
+        (WebCore::HTMLVideoElement::create):
+
 2017-10-25  Javier Fernandez  <jfernandez@igalia.com>
 

trunk/Source/WebCore/html/HTMLAudioElement.cpp

@@ -45 +45 @@
 {
     auto element = adoptRef(*new HTMLAudioElement(tagName, document, createdByParser));
+    element->finishInitialization();
     element->suspendIfNeeded();
     return element;

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -458 +458 @@
     , m_processingPreferenceChange(false)
 #endif
-    , m_mediaSession(std::make_unique<MediaElementSession>(*this))
 #if !RELEASE_LOG_DISABLED
     , m_logger(&document.logger())
@@ -469 +468 @@
 
     setHasCustomStyleResolveCallbacks();
+}
+
+void HTMLMediaElement::finishInitialization()
+{
+    m_mediaSession = std::make_unique<MediaElementSession>(*this);
 
     m_mediaSession->addBehaviorRestriction(MediaElementSession::RequireUserGestureForFullscreen);
@@ -478 +482 @@
     m_mediaSession->addBehaviorRestriction(MediaElementSession::RequirePlaybackToControlControlsManager);
 
+    auto& document = this->document();
     auto* page = document.page();
 

trunk/Source/WebCore/html/HTMLMediaElement.h

@@ -546 +546 @@
 protected:
     HTMLMediaElement(const QualifiedName&, Document&, bool createdByParser);
+    virtual void finishInitialization();
     virtual ~HTMLMediaElement();
 

trunk/Source/WebCore/html/HTMLVideoElement.cpp

@@ -65 +65 @@
 {
     auto videoElement = adoptRef(*new HTMLVideoElement(tagName, document, createdByParser));
+    videoElement->finishInitialization();
     videoElement->suspendIfNeeded();
     return videoElement;