Changeset 223998 in webkit

Timestamp:

Oct 25, 2017 4:50:11 PM (6 years ago)

Author:

webkit@devinrousso.com

Message:

Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty
​https://bugs.webkit.org/show_bug.cgi?id=178805
<rdar://problem/35176303>

Reviewed by Brian Burg.

Source/WebCore:

No new tests, updated existing tests.

• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
If the recording was stopped and had no data, reset the CallTracingActive flag to false.

LayoutTests:

• inspector/canvas/recording-2d-expected.txt:
• inspector/canvas/recording-2d.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/canvas/recording-2d-expected.txt (modified) (1 diff)
• LayoutTests/inspector/canvas/recording-2d.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/InspectorCanvasAgent.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-25  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty
+        https://bugs.webkit.org/show_bug.cgi?id=178805
+        <rdar://problem/35176303>
+
+        Reviewed by Brian Burg.
+
+        * inspector/canvas/recording-2d-expected.txt:
+        * inspector/canvas/recording-2d.html:
+
 2017-10-25  Devin Rousso  <webkit@devinrousso.com>
 

trunk/LayoutTests/inspector/canvas/recording-2d-expected.txt

@@ -1365 +1365 @@
 PASS: The parameter should be null.
 
+-- Running test case: Canvas.recording2D.NoActions
+PASS: A recording should have been started and stopped once.
+PASS: A recording should have been started and stopped twice.
+

trunk/LayoutTests/inspector/canvas/recording-2d.html

@@ -472 +472 @@
     });
 
+    suite.addTestCase({
+        name: "Canvas.recording2D.NoActions",
+        description: "Check that a canvas is still able to be recorded after stopping a recording with no actions.",
+        test(resolve, reject) {
+            let canvas = getCanvas(WI.Canvas.ContextType.Canvas2D);
+            if (!canvas)
+                throw "Missing 2D canvas.";
+
+            let eventCount = 0;
+            function handleRecordingStopped(event) {
+                InspectorTest.assert(event.data.canvas === canvas, "We should have stopped recording the selected canvas.");
+                ++eventCount;
+
+                if (eventCount == 1)
+                    InspectorTest.pass("A recording should have been started and stopped once.");
+
+                if (eventCount >= 2) {
+                    InspectorTest.pass("A recording should have been started and stopped twice.");
+
+                    WI.canvasManager.removeEventListener(handleRecordingStopped);
+                    resolve();
+                }
+            }
+            WI.canvasManager.addEventListener(WI.CanvasManager.Event.RecordingStopped, handleRecordingStopped);
+
+            WI.canvasManager.startRecording(canvas);
+            WI.canvasManager.stopRecording();
+
+            WI.canvasManager.startRecording(canvas);
+            WI.canvasManager.stopRecording();
+        },
+    });
+
     suite.runTestCasesAndFinish();
 }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-25  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty
+        https://bugs.webkit.org/show_bug.cgi?id=178805
+        <rdar://problem/35176303>
+
+        Reviewed by Brian Burg.
+
+        No new tests, updated existing tests.
+
+        * inspector/InspectorCanvasAgent.cpp:
+        (WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
+        If the recording was stopped and had no data, reset the CallTracingActive flag to false.
+
 2017-10-25  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WebCore/inspector/InspectorCanvasAgent.cpp

@@ -462 +462 @@
 
     if (!inspectorCanvas->hasRecordingData()) {
-        if (forceDispatch)
+        if (forceDispatch) {
             m_frontendDispatcher->recordingFinished(inspectorCanvas->identifier(), nullptr);
+
+            inspectorCanvas->resetRecordingData();
+        }
         return;
     }