Changeset 224062 in webkit

Timestamp:

Oct 26, 2017 4:28:31 PM (6 years ago)

Author:

keith_miller@apple.com

Message:

[Payment Request] Restrict API use to secure, same-origin frames
​https://bugs.webkit.org/show_bug.cgi?id=178887

Patch by Andy Estes <​aestes@apple.com> on 2017-10-26
Reviewed by Tim Horton.

Reuse the access checks from Apple Pay to restrict PaymentRequest API usage to secure frames
in the same origin as the main frame.

Progresses active-document-cross-origin.https.sub.html and
active-document-same-origin.https.html from web-platform-tests. Regresses basic.https.html
since the allowpaymentrequest <iframe> attribute is not yet implemented.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::supportsVersion):
(WebCore::ApplePaySession::canMakePayments):
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
(WebCore::ApplePaySession::openPaymentSetup):
(WebCore::isSecure): Deleted.
(WebCore::canCallApplePaySessionAPIs): Deleted.

• Modules/applepay/PaymentSession.cpp: Added.

(WebCore::isSecure):
(WebCore::PaymentSession::canCreateSession):

• Modules/applepay/PaymentSession.h:
• Modules/paymentrequest/PaymentHandler.cpp:

(WebCore::PaymentHandler::canCreateSession):

• Modules/paymentrequest/PaymentHandler.h:
• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create):

• WebCore.xcodeproj/project.pbxproj:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ -76 +76 @@
         * platform/mac/MediaRemoteSoftLink.cpp: Softlink kMRMediaRemoteNowPlayingInfoUniqueIdentifier.
         * platform/mac/MediaRemoteSoftLink.h:
+
+2017-10-26  Keith Miller  <keith_miller@apple.com>
+
+        Unreviewed, add deprecated declarations pragma to fix macosx.
+
+        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
 
 2017-10-26  Keith Miller  <keith_miller@apple.com>

trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm

@@ -45 +45 @@
 #import <wtf/NeverDestroyed.h>
 #import <wtf/SoftLinking.h>
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 
 SOFT_LINK_FRAMEWORK(QTKit)
@@ -1720 +1723 @@
 @end
 
+#pragma clang diagnostic pop // deprecated-declarations
+
 #endif