Changeset 224124 in webkit

Timestamp:

Oct 27, 2017 12:10:24 PM (6 years ago)

Author:

Jonathan Bedard

Message:

Windows and WebViews are retained after re-configure
​https://bugs.webkit.org/show_bug.cgi?id=178902
<rdar://problem/35211518>

Reviewed by Alexey Proskuryakov.

The test runner effectively leaks windows every time a test changes configuration.
We give each test it's own AutoreleasePool to fix this problem.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
so that when a configuration changes, the old window and WebView are released.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-27  Jonathan Bedard  <jbedard@apple.com>
+
+        Windows and WebViews are retained after re-configure
+        https://bugs.webkit.org/show_bug.cgi?id=178902
+        <rdar://problem/35211518>
+
+        Reviewed by Alexey Proskuryakov.
+
+        The test runner effectively leaks windows every time a test changes configuration.
+        We give each test it's own AutoreleasePool to fix this problem.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
+        so that when a configuration changes, the old window and WebView are released.
+
 2017-10-27  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -68 +68 @@
 #include <string>
 #include <unistd.h>
+#include <wtf/AutodrainedPool.h>
 #include <wtf/CryptographicallyRandomNumber.h>
 #include <wtf/HexNumber.h>
@@ -1177 +1178 @@
 bool TestController::runTest(const char* inputLine)
 {
+    AutodrainedPool pool;
+    
     WKTextCheckerSetTestingMode(true);
     TestCommand command = parseInputLine(std::string(inputLine));