Changeset 224168 in webkit


Ignore:
Timestamp:
Oct 29, 2017 8:40:50 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Use of uninitialized value $targetIdlFile in hash element at preprocess-idls.pl line 165.
​https://bugs.webkit.org/show_bug.cgi?id=177743

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-29
Reviewed by Darin Adler.

GamepadWebVR.idl supplements Gamepad.idl. But, Gamepad.idl is not
processed because ENABLE_GAMEPAD is OFF.

No new tests since there should be no behavioral change.

  • CMakeLists.txt: Include GamepadWebVR.idl only if ENABLE_GAMEPAD.
  • Sources.txt: Ditto.
  • bindings/scripts/preprocess-idls.pl: Die if a supplemented IDL file is not found.
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r224006 r224168  
    406406
    407407    Modules/webvr/DOMWindowWebVR.idl
    408     Modules/webvr/GamepadWebVR.idl
    409408    Modules/webvr/NavigatorWebVR.idl
    410409    Modules/webvr/VRDisplay.idl
    … …  
    997996        Modules/gamepad/GamepadEvent.idl
    998997        Modules/gamepad/NavigatorGamepad.idl
     998
     999        Modules/webvr/GamepadWebVR.idl
    9991000    )
    10001001

  • trunk/Source/WebCore/ChangeLog

    r224165 r224168  
     12017-10-29  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        Use of uninitialized value $targetIdlFile in hash element at preprocess-idls.pl line 165.
     4        https://bugs.webkit.org/show_bug.cgi?id=177743
     5
     6        Reviewed by Darin Adler.
     7
     8        GamepadWebVR.idl supplements Gamepad.idl. But, Gamepad.idl is not
     9        processed because ENABLE_GAMEPAD is OFF.
     10
     11        No new tests since there should be no behavioral change.
     12
     13        * CMakeLists.txt: Include GamepadWebVR.idl only if ENABLE_GAMEPAD.
     14        * Sources.txt: Ditto.
     15        * bindings/scripts/preprocess-idls.pl: Die if a supplemented IDL file is not found.
     16
    1172017-10-29  Sam Weinig  <sam@webkit.org>
    218

  • trunk/Source/WebCore/Sources.txt

    r224150 r224168  
    267267Modules/websockets/WorkerThreadableWebSocketChannel.cpp
    268268
    269 Modules/webvr/GamepadWebVR.cpp
    270269Modules/webvr/NavigatorWebVR.cpp
    271270Modules/webvr/VRDisplay.cpp
    … …  
    24452444JSFontFaceSet.cpp
    24462445JSGainNode.cpp
    2447 JSGamepadWebVR.cpp
    24482446JSGeolocation.cpp
    24492447JSGeoposition.cpp
    … …  
    29772975JSGamepadButton.cpp
    29782976JSGamepadEvent.cpp
     2977JSGamepadWebVR.cpp
    29792978JSNavigatorGamepad.cpp
     2979
     2980Modules/webvr/GamepadWebVR.cpp
    29802981
    29812982#endif

  • trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl

    r223629 r224168  
    162162    my $baseFiles = $supplementalDependencies{$idlFile};
    163163    foreach my $baseFile (@{$baseFiles}) {
    164         my $targetIdlFile = $interfaceNameToIdlFile{$baseFile};
     164        my $targetIdlFile = $interfaceNameToIdlFile{$baseFile} or die "${baseFile}.idl not found, but it is supplemented by $idlFile";
    165165        push(@{$supplementals{$targetIdlFile}}, $idlFile);
    166166    }
Note: See TracChangeset for help on using the changeset viewer.