Changeset 224172 in webkit

Timestamp:

Oct 30, 2017 1:17:42 AM (6 years ago)

Author:

zandobersek@gmail.com

Message:

[ARMv7] Fix initial start register support in YarrJIT
​https://bugs.webkit.org/show_bug.cgi?id=178641

Reviewed by Saam Barati.

• yarr/YarrJIT.cpp: On ARMv7, use r8 as the initialStart register in the

YarrGenerator class. r6 should be avoided since it's already used inside
MacroAssemblerARMv7 as addressTempRegister. r7 isn't picked because it
can be used as the frame pointer register when targetting ARM Thumb2.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• yarr/YarrJIT.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-10-30  Zan Dobersek  <zdobersek@igalia.com>
+
+        [ARMv7] Fix initial start register support in YarrJIT
+        https://bugs.webkit.org/show_bug.cgi?id=178641
+
+        Reviewed by Saam Barati.
+
+        * yarr/YarrJIT.cpp: On ARMv7, use r8 as the initialStart register in the
+        YarrGenerator class. r6 should be avoided since it's already used inside
+        MacroAssemblerARMv7 as addressTempRegister. r7 isn't picked because it
+        can be used as the frame pointer register when targetting ARM Thumb2.
+
 2017-10-30  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/JavaScriptCore/yarr/YarrJIT.cpp

@@ -52 +52 @@
     static const RegisterID regT0 = ARMRegisters::r4;
     static const RegisterID regT1 = ARMRegisters::r5;
-    static const RegisterID initialStart = ARMRegisters::r6;
+    static const RegisterID initialStart = ARMRegisters::r8;
 
     static const RegisterID returnRegister = ARMRegisters::r0;