Changeset 224203 in webkit

Timestamp:

Oct 30, 2017 3:08:01 PM (6 years ago)

Author:

Ross Kirsling

Message:

Web Inspector: Clicking filler in data grid should clear selection
​https://bugs.webkit.org/show_bug.cgi?id=179027

Reviewed by Brian Burg.

• UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype._mouseDownInDataTable):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DataGrid.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-10-30  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Web Inspector: Clicking filler in data grid should clear selection
+        https://bugs.webkit.org/show_bug.cgi?id=179027
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/DataGrid.js:
+        (WI.DataGrid.prototype._mouseDownInDataTable):
+
 2017-10-30  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js

@@ -1571 +1571 @@
     {
         var gridNode = this.dataGridNodeFromNode(event.target);
-        if (!gridNode || !gridNode.selectable)
-            return;
-
-        if (gridNode.isEventWithinDisclosureTriangle(event))
+        if (!gridNode) {
+            if (this.selectedNode)
+                this.selectedNode.deselect();
+            
+            return;
+        }
+
+        if (!gridNode.selectable || gridNode.isEventWithinDisclosureTriangle(event))
             return;