Changeset 224225 in webkit

Timestamp:

Oct 31, 2017 1:39:38 AM (6 years ago)

Author:

rniwa@webkit.org

Message:

Assert that no script is executed during LayoutPhase::InRenderTreeLayout
​https://bugs.webkit.org/show_bug.cgi?id=179046

Reviewed by Antti Koivisto.

Added NoEventDispatchAssertion to LayoutPhase::InRenderTreeLayout.

• page/LayoutContext.cpp:

(WebCore::LayoutContext::layout):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/LayoutContext.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-30  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Assert that no script is executed during LayoutPhase::InRenderTreeLayout
+        https://bugs.webkit.org/show_bug.cgi?id=179046
+
+        Reviewed by Antti Koivisto.
+
+        Added NoEventDispatchAssertion to LayoutPhase::InRenderTreeLayout.
+
+        * page/LayoutContext.cpp:
+        (WebCore::LayoutContext::layout):
+
 2017-10-31  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebCore/page/LayoutContext.cpp

@@ -33 +33 @@
 #include "InspectorInstrumentation.h"
 #include "Logging.h"
+#include "NoEventDispatchAssertion.h"
 #include "RenderElement.h"
 #include "RenderView.h"
@@ -211 +212 @@
     {
         SetForScope<LayoutPhase> layoutPhase(m_layoutPhase, LayoutPhase::InRenderTreeLayout);
-    
+        NoEventDispatchAssertion noEventDispatchAssertion;
         SubtreeLayoutStateMaintainer subtreeLayoutStateMaintainer(subtreeLayoutRoot());
         RenderView::RepaintRegionAccumulator repaintRegionAccumulator(renderView());
@@ -223 +224 @@
 #endif
         clearSubtreeLayoutRoot();
-
     }
     {