Changeset 224249 in webkit

Timestamp:

Oct 31, 2017 2:43:58 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: UIProcess ASSERT in ~RemoteWebInspectorProxy when InspectorProcess crashes
​https://bugs.webkit.org/show_bug.cgi?id=179044

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-31
Reviewed by Alex Christensen.

• UIProcess/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::frontendDidClose):
Add a protector to keep the proxy alive for the duration of this method.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/RemoteWebInspectorProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-10-31  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: UIProcess ASSERT in ~RemoteWebInspectorProxy when InspectorProcess crashes
+        https://bugs.webkit.org/show_bug.cgi?id=179044
+
+        Reviewed by Alex Christensen.
+
+        * UIProcess/RemoteWebInspectorProxy.cpp:
+        (WebKit::RemoteWebInspectorProxy::frontendDidClose):
+        Add a protector to keep the proxy alive for the duration of this method.
+
 2017-10-31  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp

@@ -83 +83 @@
 void RemoteWebInspectorProxy::frontendDidClose()
 {
+    Ref<RemoteWebInspectorProxy> protect(*this);
+
     if (m_client)
         m_client->closeFromFrontend();