Changeset 224256 in webkit

Timestamp:

Oct 31, 2017 3:41:22 PM (6 years ago)

Author:

Wenson Hsieh

Message:

Followup to r224238: API::Attachment should generate a _WKAttachment ObjC wrapper
​https://bugs.webkit.org/show_bug.cgi?id=179080

Reviewed by Tim Horton.

Fixes a failing API test. The new Attachment object type added in r224238 was not actually being handled in
Object::newObject, so a plain WKObject Objective C wrapper was being created; fix this by allocating a new
_WKAttachment object for Type::Attachment.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/Cocoa/APIObject.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Followup to r224238: API::Attachment should generate a _WKAttachment ObjC wrapper
+        https://bugs.webkit.org/show_bug.cgi?id=179080
+
+        Reviewed by Tim Horton.
+
+        Fixes a failing API test. The new Attachment object type added in r224238 was not actually being handled in
+        Object::newObject, so a plain WKObject Objective C wrapper was being created; fix this by allocating a new
+        _WKAttachment object for Type::Attachment.
+
+        * Shared/Cocoa/APIObject.mm:
+        (API::Object::newObject):
+
 2017-10-31  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/Shared/Cocoa/APIObject.mm

@@ -69 +69 @@
 #import "WKWebsiteDataStoreInternal.h"
 #import "WKWindowFeaturesInternal.h"
+#import "_WKAttachmentInternal.h"
 #import "_WKAutomationSessionInternal.h"
 #import "_WKDownloadInternal.h"
@@ -106 +107 @@
         break;
 
+    case Type::Attachment:
+        wrapper = [_WKAttachment alloc];
+        break;
+
     case Type::AuthenticationChallenge:
         wrapper = NSAllocateObject([WKNSURLAuthenticationChallenge self], size, nullptr);