Changeset 224278 in webkit

Timestamp:

Nov 1, 2017 8:36:49 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Fix ContinuationChainNode::insertAfter assertion.
​https://bugs.webkit.org/show_bug.cgi?id=179115

Patch by Emilio Cobos Álvarez <emilio> on 2017-11-01
Reviewed by Antti Koivisto.

The assertion was writing instead of reading next->previous.

Hopefully it's harmless because it was clobbered on the same line, but
it's worth asserting what it was intending to assert.

No new tests (no behaviour change).

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::ContinuationChainNode::insertAfter):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBoxModelObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-11-01  Emilio Cobos Álvarez  <emilio@crisal.io>
+
+        Fix ContinuationChainNode::insertAfter assertion.
+        https://bugs.webkit.org/show_bug.cgi?id=179115
+
+        Reviewed by Antti Koivisto.
+
+        The assertion was writing instead of reading next->previous.
+
+        Hopefully it's harmless because it was clobbered on the same line, but
+        it's worth asserting what it was intending to assert.
+
+        No new tests (no behaviour change).
+
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::ContinuationChainNode::insertAfter):
+
 2017-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -115 +115 @@
     ASSERT(!next);
     if ((next = after.next)) {
-        ASSERT(next->previous = &after);
+        ASSERT(next->previous == &after);
         next->previous = this;
     }