Changeset 224283 in webkit


Ignore:
Timestamp:
Nov 1, 2017 11:43:57 AM (6 years ago)
Author:
dino@apple.com
Message:

transferFromImageBitmap should update canvas dimensions
​https://bugs.webkit.org/show_bug.cgi?id=179096
<rdar://problem/35285218>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Update expected results now that we pass more of this test.

  • web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt:

Source/WebCore:

When transferFromImageBitmap is called, the dimensions of the HTMLCanvasElement
should be updated to reflect the size of the passed ImageBitmap.

Update an existing WPT result.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::setImageBuffer const): Update the
size of the element based on the incoming buffer.

  • html/HTMLCanvasElement.h: Mark m_size as mutable so we can

call it from the const function setImageBuffer.

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r224271 r224283  
     12017-10-31  Dean Jackson  <dino@apple.com>
     2
     3        transferFromImageBitmap should update canvas dimensions
     4        https://bugs.webkit.org/show_bug.cgi?id=179096
     5        <rdar://problem/35285218>
     6
     7        Reviewed by Sam Weinig.
     8
     9        Update expected results now that we pass more of this test.
     10
     11        * web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt:
     12
    1132017-10-31  Chris Dumez  <cdumez@apple.com>
    214

  • trunk/LayoutTests/imported/w3c/web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt

    r224195 r224283  
    11
    2 FAIL Test that createImageBitmap from a bitmaprenderer canvas produces correct result assert_equals: expected 10 but got 20
     2PASS Test that createImageBitmap from a bitmaprenderer canvas produces correct result
    33PASS Test that createImageBitmap on a bitmaprenderer canvas that never consumes any source produces correct result
    44PASS Test that createImageBitmap on a bitmaprenderer canvas that consumes null produces correct result

  • trunk/Source/WebCore/ChangeLog

    r224280 r224283  
     12017-10-31  Dean Jackson  <dino@apple.com>
     2
     3        transferFromImageBitmap should update canvas dimensions
     4        https://bugs.webkit.org/show_bug.cgi?id=179096
     5        <rdar://problem/35285218>
     6
     7        Reviewed by Sam Weinig.
     8
     9        When transferFromImageBitmap is called, the dimensions of the HTMLCanvasElement
     10        should be updated to reflect the size of the passed ImageBitmap.
     11
     12        Update an existing WPT result.
     13
     14        * html/HTMLCanvasElement.cpp:
     15        (WebCore::HTMLCanvasElement::setImageBuffer const): Update the
     16        size of the element based on the incoming buffer.
     17        * html/HTMLCanvasElement.h: Mark m_size as mutable so we can
     18        call it from the const function setImageBuffer.
     19
    1202017-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
    221

  • trunk/Source/WebCore/html/HTMLCanvasElement.cpp

    r224255 r224283  
    979979    }
    980980
     981    if (m_imageBuffer && m_size != m_imageBuffer->internalSize())
     982        m_size = m_imageBuffer->internalSize();
     983
    981984    size_t currentMemoryCost = memoryCost();
    982985    activePixelMemory += currentMemoryCost;

  • trunk/Source/WebCore/html/HTMLCanvasElement.h

    r224255 r224283  
    201201
    202202    FloatRect m_dirtyRect;
    203     IntSize m_size;
     203    mutable IntSize m_size;
    204204
    205205    bool m_originClean { true };
Note: See TracChangeset for help on using the changeset viewer.