Changeset 224323 in webkit


Ignore:
Timestamp:
Nov 1, 2017 10:57:25 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Remove ScrollableArea::isTouchScrollable and ScrollableArea::isOverflowScroll
https://bugs.webkit.org/show_bug.cgi?id=179121

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-01
Reviewed by Alex Christensen.

These functions were introduced in r161589 and r160236 but it seems that they have never
been used.

No new tests, behavior unchanged.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::isTouchScrollable const): Deleted.
(WebCore::ScrollableArea::isOverflowScroll const): Deleted.

  • rendering/RenderLayer.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r224322 r224323  
     12017-11-01  Frederic Wang  <fwang@igalia.com>
     2
     3        Remove ScrollableArea::isTouchScrollable and ScrollableArea::isOverflowScroll
     4        https://bugs.webkit.org/show_bug.cgi?id=179121
     5
     6        Reviewed by Alex Christensen.
     7
     8        These functions were introduced in r161589 and r160236 but it seems that they have never
     9        been used.
     10
     11        No new tests, behavior unchanged.
     12
     13        * platform/ScrollableArea.h:
     14        (WebCore::ScrollableArea::isTouchScrollable const): Deleted.
     15        (WebCore::ScrollableArea::isOverflowScroll const): Deleted.
     16        * rendering/RenderLayer.h:
     17
    1182017-11-01  Basuke Suzuki  <Basuke.Suzuki@sony.com>
    219
  • trunk/Source/WebCore/platform/ScrollableArea.h

    r224260 r224323  
    9090
    9191#if ENABLE(TOUCH_EVENTS)
    92     virtual bool isTouchScrollable() const { return false; }
    9392    virtual bool handleTouchEvent(const PlatformTouchEvent&);
    9493#endif
    9594
    9695#if PLATFORM(IOS)
    97     virtual bool isOverflowScroll() const { return false; }
    9896    virtual void didStartScroll() { }
    9997    virtual void didEndScroll() { }
  • trunk/Source/WebCore/rendering/RenderLayer.h

    r224265 r224323  
    245245#if ENABLE(TOUCH_EVENTS)
    246246    bool handleTouchEvent(const PlatformTouchEvent&) override;
    247     bool isTouchScrollable() const override { return true; }
    248 #endif
    249     bool isOverflowScroll() const override { return true; }
     247#endif
    250248   
    251249    void didStartScroll() override;
Note: See TracChangeset for help on using the changeset viewer.