Changeset 224475 in webkit

Timestamp:

Nov 5, 2017 7:47:05 PM (6 years ago)

Author:

webkit@devinrousso.com

Message:

Web Inspector: Canvas Tab: selecting Frame tree element should update preview/slider, does nothing
​https://bugs.webkit.org/show_bug.cgi?id=179072
<rdar://problem/35278711>

Reviewed by Matt Baker.

• UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype._navigationSidebarTreeOutlineSelectionChanged):

• UserInterface/Views/RecordingActionTreeElement.css:

(.item.action > .titles .parameter.swizzled):
(.tree-outline:not(:focus, .force-focus) .item.action:not(.initial-state, .parent, .invalid) > .icon): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .item.action > .titles .parameter.swizzled): Deleted.
Drive-by: remove extra :focus selectors to prevent icon flashing when the window is blurred.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasTabContentView.js (modified) (1 diff)
• UserInterface/Views/RecordingActionTreeElement.css (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-11-05  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: Canvas Tab: selecting Frame tree element should update preview/slider, does nothing
+        https://bugs.webkit.org/show_bug.cgi?id=179072
+        <rdar://problem/35278711>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/CanvasTabContentView.js:
+        (WI.CanvasTabContentView.prototype._navigationSidebarTreeOutlineSelectionChanged):
+
+        * UserInterface/Views/RecordingActionTreeElement.css:
+        (.item.action > .titles .parameter.swizzled):
+        (.tree-outline:not(:focus, .force-focus) .item.action:not(.initial-state, .parent, .invalid) > .icon): Deleted.
+        (body:not(.window-inactive, .window-docked-inactive) .item.action > .titles .parameter.swizzled): Deleted.
+        Drive-by: remove extra :focus selectors to prevent icon flashing when the window is blurred.
+
 2017-11-04  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js

@@ -272 +272 @@
             return;
 
+        let recordingContentView = this.contentBrowser.currentContentView;
+        if (!(recordingContentView instanceof WI.RecordingContentView))
+            return;
+
         let selectedTreeElement = event.data.selectedElement;
         if (selectedTreeElement instanceof WI.FolderTreeElement)
-            return;
-
-        let recordingContentView = this.contentBrowser.currentContentView;
-        if (!(recordingContentView instanceof WI.RecordingContentView))
-            return;
+            selectedTreeElement = selectedTreeElement.children.lastValue;
 
         this._updateActionIndex(selectedTreeElement.index, {suppressNavigationSidebarUpdate: true});

trunk/Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css

@@ -28 +28 @@
 }
 
-.tree-outline:not(:focus, .force-focus) .item.action:not(.initial-state, .parent, .invalid) > .icon {
-    opacity: 0.7;
-}
-
 .item.action:not(.initial-state)::before {
     position: relative;
@@ -62 +58 @@
 }
 
-body:not(.window-inactive, .window-docked-inactive) .item.action > .titles .parameter.swizzled {
+.item.action > .titles .parameter.swizzled {
     color: var(--text-color-gray-medium);
 }