Changeset 224543 in webkit

Timestamp:

Nov 7, 2017 12:17:55 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

<video> does not respect pointer-events
​https://bugs.webkit.org/show_bug.cgi?id=179378
<rdar://problem/34687668>

Patch by Antoine Quint <Antoine Quint> on 2017-11-07
Reviewed by Simon Fraser.

Source/WebCore:

We now honor the "pointer-events" property value set on the <video> element by setting it to "inherit"
on the media controls shadow root container.

Test: media/modern-media-controls/css/pointer-events-none.html

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls-container):

LayoutTests:

Add a new test that checks that settings "pointer-events: none" on the <video> element
correctly reflects that same value on the media controls shadow root container.

• media/modern-media-controls/css/pointer-events-none-expected.txt: Added.
• media/modern-media-controls/css/pointer-events-none.html: Added.
• platform/ios/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/modern-media-controls/css/pointer-events-none-expected.txt (added)
• LayoutTests/media/modern-media-controls/css/pointer-events-none.html (added)
• LayoutTests/platform/ios/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-11-07  Antoine Quint  <graouts@apple.com>
+
+        <video> does not respect pointer-events
+        https://bugs.webkit.org/show_bug.cgi?id=179378
+        <rdar://problem/34687668>
+
+        Reviewed by Simon Fraser.
+
+        Add a new test that checks that settings "pointer-events: none" on the <video> element
+        correctly reflects that same value on the media controls shadow root container.
+
+        * media/modern-media-controls/css/pointer-events-none-expected.txt: Added.
+        * media/modern-media-controls/css/pointer-events-none.html: Added.
+        * platform/ios/TestExpectations:
+
 2017-11-07  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/platform/ios/TestExpectations

@@ -173 +173 @@
 platform/ios/ios/fast/text/data-detectors/phone.html [ Skip ]
 platform/ios/ios/touch [ Skip ]
+media/modern-media-controls/css/pointer-events-none.html [ Skip ]
 
 # Codecs not supported

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-11-07  Antoine Quint  <graouts@apple.com>
+
+        <video> does not respect pointer-events
+        https://bugs.webkit.org/show_bug.cgi?id=179378
+        <rdar://problem/34687668>
+
+        Reviewed by Simon Fraser.
+
+        We now honor the "pointer-events" property value set on the <video> element by setting it to "inherit"
+        on the media controls shadow root container.
+
+        Test: media/modern-media-controls/css/pointer-events-none.html
+
+        * Modules/modern-media-controls/controls/media-controls.css:
+        (.media-controls-container):
+
 2017-11-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

@@ -55 +55 @@
     display: block;
     visibility: inherit;
+    pointer-events: inherit;
     -webkit-cursor-visibility: inherit;
     position: relative;