Changeset 225171 in webkit

Timestamp:

Nov 27, 2017 8:30:58 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r223073): disk cache directory is no longer copied in ProcessPoolConfiguration::copy()
​https://bugs.webkit.org/show_bug.cgi?id=180031

Reviewed by Youenn Fablet.

This has caused GTK/WPE test /webkit2/WebKitWebsiteData/configuration to fail, and the wrong directory is used
by the network process. I think it was removed by mistake in r223073.

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy): Copy m_diskCacheDirectory too.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/APIProcessPoolConfiguration.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r223073): disk cache directory is no longer copied in ProcessPoolConfiguration::copy()
+        https://bugs.webkit.org/show_bug.cgi?id=180031
+
+        Reviewed by Youenn Fablet.
+
+        This has caused GTK/WPE test /webkit2/WebKitWebsiteData/configuration to fail, and the wrong directory is used
+        by the network process. I think it was removed by mistake in r223073.
+
+        * UIProcess/API/APIProcessPoolConfiguration.cpp:
+        (API::ProcessPoolConfiguration::copy): Copy m_diskCacheDirectory too.
+
 2017-11-27  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp

@@ -100 +100 @@
     copy->m_maximumProcessCount = this->m_maximumProcessCount;
     copy->m_cacheModel = this->m_cacheModel;
+    copy->m_diskCacheDirectory = this->m_diskCacheDirectory;
     copy->m_diskCacheSpeculativeValidationEnabled = this->m_diskCacheSpeculativeValidationEnabled;
     copy->m_diskCacheSizeOverride = this->m_diskCacheSizeOverride;