Changeset 225240 in webkit

Timestamp:

Nov 28, 2017 2:39:04 PM (6 years ago)

Author:

ap@apple.com

Message:

Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
​https://bugs.webkit.org/show_bug.cgi?id=118505

Reviewed by Joseph Pecoraro.

• Scripts/valgrind/suppressions.txt:
• Scripts/webkitpy/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/valgrind/suppressions.txt (modified) (1 diff)
• Scripts/webkitpy/port/leakdetector.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-11-28  Alexey Proskuryakov  <ap@apple.com>
+
+        Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
+        https://bugs.webkit.org/show_bug.cgi?id=118505
+
+        Reviewed by Joseph Pecoraro.
+
+        * Scripts/valgrind/suppressions.txt:
+        * Scripts/webkitpy/port/leakdetector.py:
+        (LeakDetector._callstacks_to_exclude_from_leaks):
+
 2017-11-28  Ms2ger  <Ms2ger@igalia.com>
 

trunk/Tools/Scripts/valgrind/suppressions.txt

@@ -595 +595 @@
 
 {
-   # TextCodecICU::registerCodecs is leaking https://bugs.webkit.org/show_bug.cgi?id=118505
-   WebCore::TextCodec::registerCodecs()
    Memcheck:Leak
    fun:malloc

trunk/Tools/Scripts/webkitpy/port/leakdetector.py

@@ -55 +55 @@
     def _callstacks_to_exclude_from_leaks(self):
         callstacks = [
-            'TextCodecICU::registerCodecs',  # https://bugs.webkit.org/show_bug.cgi?id=118505
+            # List substrings here, e.g.
+            # 'TextCodecICU::registerCodecs',  # https://bugs.webkit.org/show_bug.cgi?id=118505
         ]
-        if self._port.operating_system == 'mac' and self._port.is_mavericks():
-            callstacks += [
-                'AVAssetResourceLoader _poseAuthenticationChallengeWithKey:data:requestDictionary:fallbackHandler:',  # <rdar://problem/19699887> leak in AVFoundation
-            ]
         return callstacks