Changeset 225258 in webkit

Timestamp:

Nov 28, 2017 10:10:50 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Write script syntax tree tests for template literals and default parameter values
​https://bugs.webkit.org/show_bug.cgi?id=149450
<rdar://problem/22796879>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Devin Rousso.

• inspector/model/parse-script-syntax-tree-expected.txt:
• inspector/model/parse-script-syntax-tree.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/model/parse-script-syntax-tree-expected.txt (modified) (1 diff)
• inspector/model/parse-script-syntax-tree.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-11-28  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Write script syntax tree tests for template literals and default parameter values
+        https://bugs.webkit.org/show_bug.cgi?id=149450
+        <rdar://problem/22796879>
+
+        Reviewed by Devin Rousso.
+
+        * inspector/model/parse-script-syntax-tree-expected.txt:
+        * inspector/model/parse-script-syntax-tree.html:
+
 2017-11-28  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/inspector/model/parse-script-syntax-tree-expected.txt

@@ -21 +21 @@
 passed IfStatement
 passed Literal
+passed TemplateLiteral, TemplateElement
+passed TaggedTemplateExpression
 passed LabeledStatement
 passed LogicalExpression

trunk/LayoutTests/inspector/model/parse-script-syntax-tree.html

@@ -272 +272 @@
     InspectorTest.assert(node.value === "a");
     InspectorTest.assert(node.raw === "\"a\"");
+    node = makeNode("'abc'", true);
+    InspectorTest.assert(node.value === "abc");
+    InspectorTest.assert(node.raw === "'abc'");
     InspectorTest.log("passed Literal");
+
+    node = makeNode("`abc`", true);
+    InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.TemplateLiteral);
+    InspectorTest.assert(node.quasis.length === 1);
+    InspectorTest.assert(node.expressions.length === 0);
+    InspectorTest.assert(node.quasis[0].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasis[0].value.raw === "abc");
+    node = makeNode("`abc${1}def`", true);
+    InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.TemplateLiteral);
+    InspectorTest.assert(node.quasis.length === 2);
+    InspectorTest.assert(node.expressions.length === 1);
+    InspectorTest.assert(node.quasis[0].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasis[0].value.raw === "abc");
+    InspectorTest.assert(node.quasis[1].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasis[1].value.raw === "def");
+    InspectorTest.assert(node.expressions[0].type === WI.ScriptSyntaxTree.NodeType.Literal);
+    InspectorTest.assert(node.expressions[0].value === 1);
+    InspectorTest.log("passed TemplateLiteral, TemplateElement");
+
+    node = makeNode("tag`abcd`", true);
+    InspectorTest.assert(node.type === WI.ScriptSyntaxTree.NodeType.TaggedTemplateExpression);
+    InspectorTest.assert(node.tag.name === "tag");
+    InspectorTest.assert(node.quasi.type === WI.ScriptSyntaxTree.NodeType.TemplateLiteral);
+    InspectorTest.assert(node.quasi.quasis.length === 1);
+    InspectorTest.assert(node.quasi.expressions.length === 0);
+    InspectorTest.assert(node.quasi.quasis[0].type === WI.ScriptSyntaxTree.NodeType.TemplateElement);
+    InspectorTest.assert(node.quasi.quasis[0].value.raw === "abcd");
+    InspectorTest.log("passed TaggedTemplateExpression");
 
     node = makeNode("label:while(true)20;", false);
@@ -540 +571 @@
     InspectorTest.assert(node.declarations[0].id.elements[0].right.type === WI.ScriptSyntaxTree.NodeType.Literal);
     InspectorTest.assert(node.declarations[0].id.elements[0].right.value === 20);
+    node = makeNode("function foo(a, b=1) { return a + b; }", false);
+    InspectorTest.assert(node.params.length === 2);
+    InspectorTest.assert(node.params[0].type === WI.ScriptSyntaxTree.NodeType.Identifier);
+    InspectorTest.assert(node.params[0].name === "a");
+    InspectorTest.assert(node.params[1].type === WI.ScriptSyntaxTree.NodeType.AssignmentPattern);
+    InspectorTest.assert(node.params[1].left.type === WI.ScriptSyntaxTree.NodeType.Identifier);
+    InspectorTest.assert(node.params[1].left.name === "b");
+    InspectorTest.assert(node.params[1].right.type === WI.ScriptSyntaxTree.NodeType.Literal);
+    InspectorTest.assert(node.params[1].right.value === 1);
     InspectorTest.log("passed AssignmentPattern");