Changeset 225265 in webkit

Timestamp:

Nov 29, 2017 5:31:36 AM (6 years ago)

Author:

graouts@webkit.org

Message:

Pressing the space bar while watching a fullscreen video doesn't play or pause
​https://bugs.webkit.org/show_bug.cgi?id=180033
<rdar://problem/33610443>

Reviewed by Eric Carlson.

Source/WebCore:

We register a "keydown" event to track when the space bar is pressed, and if the media is playing
in fullscreen, we toggle playback. This does not interfere with full keyboard access since activating
one of the media controls using the keyboard will not let the events we register for be dispatched
this far along the event dispatch phase.

Test: media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.togglePlayback): Add a catch() statement since calling play() could sometime
lead to some extraneous unhandled promise console logging that pollutes test output.
(MediaController.prototype.handleEvent):

LayoutTests:

Adding a new macOS-only test that checks that pressing the space bar while playing fullscreen
pauses the media and resumes it when pressing the space bar again.

• media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt: Added.
• media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html: Added.
• media/video-test.js:

(runWithKeyDown): Update the key to not be space since this would cause media to be paused when entering fullscreen.

• platform/ios-simulator/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt (added)
• LayoutTests/media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html (added)
• LayoutTests/media/video-test.js (modified) (1 diff)
• LayoutTests/platform/ios-simulator/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/modern-media-controls/media/media-controller.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-11-29  Antoine Quint  <graouts@apple.com>
+
+        Pressing the space bar while watching a fullscreen video doesn't play or pause
+        https://bugs.webkit.org/show_bug.cgi?id=180033
+        <rdar://problem/33610443>
+
+        Reviewed by Eric Carlson.
+
+        Adding a new macOS-only test that checks that pressing the space bar while playing fullscreen
+        pauses the media and resumes it when pressing the space bar again.
+
+        * media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt: Added.
+        * media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html: Added.
+        * media/video-test.js:
+        (runWithKeyDown): Update the key to not be space since this would cause media to be paused when entering fullscreen.
+        * platform/ios-simulator/TestExpectations:
+
 2017-11-28  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/LayoutTests/media/video-test.js

@@ -415 +415 @@
     if (window.testRunner) {
         if (eventSender.keyDown)
-            eventSender.keyDown(" ", []);
+            eventSender.keyDown("a", []);
         else
             eventSender.mouseDown();

trunk/LayoutTests/platform/ios-simulator/TestExpectations

@@ -129 +129 @@
 media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Skip ]
 media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
 media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-11-29  Antoine Quint  <graouts@apple.com>
+
+        Pressing the space bar while watching a fullscreen video doesn't play or pause
+        https://bugs.webkit.org/show_bug.cgi?id=180033
+        <rdar://problem/33610443>
+
+        Reviewed by Eric Carlson.
+
+        We register a "keydown" event to track when the space bar is pressed, and if the media is playing
+        in fullscreen, we toggle playback. This does not interfere with full keyboard access since activating
+        one of the media controls using the keyboard will not let the events we register for be dispatched
+        this far along the event dispatch phase.
+
+        Test: media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html
+
+        * Modules/modern-media-controls/media/media-controller.js:
+        (MediaController):
+        (MediaController.prototype.togglePlayback): Add a catch() statement since calling play() could sometime
+        lead to some extraneous unhandled promise console logging that pollutes test output.
+        (MediaController.prototype.handleEvent):
+
 2017-11-28  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js

@@ -58 +58 @@
 
         media.addEventListener(this.fullscreenChangeEventType, this);
+
+        window.addEventListener("keydown", this);
     }
 
@@ -101 +103 @@
     {
         if (this.media.paused)
-            this.media.play();
+            this.media.play().catch(e => {});
         else
             this.media.pause();
@@ -159 +161 @@
             if (event.type === "webkitpresentationmodechanged")
                 this._returnMediaLayerToInlineIfNeeded();
+        } else if (event.type === "keydown" && this.isFullscreen && event.key === " ") {
+            this.togglePlayback();
+            event.preventDefault();
         }
     }