Changeset 225458 in webkit

Timestamp:

Dec 3, 2017 1:07:25 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

[GStreamer] GstCaps leaked in MediaPlayerPrivateGStreamer::createGSTPlayBin
​https://bugs.webkit.org/show_bug.cgi?id=180311

Reviewed by Michael Catanzaro.

gst_caps_new_empty_simple() is passed directly to g_object_set(). The returned caps should be freed with
gst_caps_unref().

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GStreamer] GstCaps leaked in MediaPlayerPrivateGStreamer::createGSTPlayBin
+        https://bugs.webkit.org/show_bug.cgi?id=180311
+
+        Reviewed by Michael Catanzaro.
+
+        gst_caps_new_empty_simple() is passed directly to g_object_set(). The returned caps should be freed with
+        gst_caps_unref().
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+
 2017-12-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -2114 +2114 @@
     ASSERT(m_textAppSinkPad);
 
-    g_object_set(m_textAppSink.get(), "emit-signals", true, "enable-last-sample", false, "caps", gst_caps_new_empty_simple("text/vtt"), nullptr);
+    GRefPtr<GstCaps> textCaps = adoptGRef(gst_caps_new_empty_simple("text/vtt"));
+    g_object_set(m_textAppSink.get(), "emit-signals", TRUE, "enable-last-sample", FALSE, "caps", textCaps.get(), nullptr);
     g_signal_connect_swapped(m_textAppSink.get(), "new-sample", G_CALLBACK(newTextSampleCallback), this);