Changeset 225493 in webkit


Ignore:
Timestamp:
Dec 4, 2017 2:06:50 PM (6 years ago)
Author:
jfbastien@apple.com
Message:

Proxy all functions, except the $ objects
https://bugs.webkit.org/show_bug.cgi?id=180375

Reviewed by Saam Barati.

It looks like this test may have broken some executions because I
call some internal objects. Explicitly ignore objects whose name
starts with "$" because it's a bad idea anyways.

  • stress/proxy-all-the-parameters.js:

(generateObjects):
(get throw):

Location:
trunk/JSTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/JSTests/ChangeLog

    r225492 r225493  
     12017-12-04  JF Bastien  <jfbastien@apple.com>
     2
     3        Proxy all functions, except the $ objects
     4        https://bugs.webkit.org/show_bug.cgi?id=180375
     5
     6        Reviewed by Saam Barati.
     7
     8        It looks like this test may have broken some executions because I
     9        call some internal objects. Explicitly ignore objects whose name
     10        starts with "$" because it's a bad idea anyways.
     11
     12        * stress/proxy-all-the-parameters.js:
     13        (generateObjects):
     14        (get throw):
     15
    1162017-12-04  Saam Barati  <sbarati@apple.com>
    217
  • trunk/JSTests/stress/proxy-all-the-parameters.js

    r225444 r225493  
    11const verbose = false;
    2 
    3 const ignore = ['quit', 'readline', 'waitForReport', 'flashHeapAccess', 'leaving', 'getReport'];
    42
    53function isPropertyOfType(obj, name, type) {
     
    2321    let obj_names = getProperties(root, 'object');
    2422    for (let obj_name of obj_names) {
     23        if (obj_name.startsWith('$'))
     24            continue; // Ignore internal objects.
    2525        let obj = root[obj_name];
    2626        yield obj;
     
    4545for (let o of getObjects()) {
    4646    for (let f of getFunctions(o)) {
    47         if (ignore.includes(f))
    48             continue;
    4947        const arityPlusOne = o[f].length + 1;
    5048        if (verbose)
Note: See TracChangeset for help on using the changeset viewer.