Changeset 225496 in webkit

Timestamp:

Dec 4, 2017 2:51:13 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Exclude some more leak callstacks
​https://bugs.webkit.org/show_bug.cgi?id=180379

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-04
Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/port/leakdetector.py:

(LeakDetector._types_to_exclude_from_leaks):
(LeakDetector._callstacks_to_exclude_from_leaks):
(LeakDetector._leaks_args):
(LeakDetector._types_to_exlude_from_leaks): Deleted.

• Scripts/webkitpy/port/leakdetector_unittest.py:

(LeakDetectorTest.test_leaks_args):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/leakdetector.py (modified) (3 diffs)
• Scripts/webkitpy/port/leakdetector_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-12-04  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Exclude some more leak callstacks
+        https://bugs.webkit.org/show_bug.cgi?id=180379
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/port/leakdetector.py:
+        (LeakDetector._types_to_exclude_from_leaks):
+        (LeakDetector._callstacks_to_exclude_from_leaks):
+        (LeakDetector._leaks_args):
+        (LeakDetector._types_to_exlude_from_leaks): Deleted.
+        * Scripts/webkitpy/port/leakdetector_unittest.py:
+        (LeakDetectorTest.test_leaks_args):
+
 2017-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Tools/Scripts/webkitpy/port/leakdetector.py

@@ -49 +49 @@
     # versions of the system frameworks that are being used by the leaks bots. Even though a leak has been
     # fixed, it will be listed here until the bot has been updated with the newer frameworks.
-    def _types_to_exlude_from_leaks(self):
+    def _types_to_exclude_from_leaks(self):
         # Currently we don't have any type excludes from OS leaks, but we will likely again in the future.
         return []
@@ -56 +56 @@
         callstacks = [
             'WTF::BitVector::OutOfLineBits::create', # https://bugs.webkit.org/show_bug.cgi?id=121662
+            'WebCore::createPrivateStorageSession', # <rdar://problem/35189565>
+            'CIDeviceManagerStartMonitoring', # <rdar://problem/35711052>
+            'NSSpellChecker init', # <rdar://problem/35434615>
         ]
         return callstacks
@@ -63 +66 @@
         for callstack in self._callstacks_to_exclude_from_leaks():
             leaks_args += ['--exclude-callstack=%s' % callstack]
-        for excluded_type in self._types_to_exlude_from_leaks():
+        for excluded_type in self._types_to_exclude_from_leaks():
             leaks_args += ['--exclude-type=%s' % excluded_type]
         leaks_args.append(pid)

trunk/Tools/Scripts/webkitpy/port/leakdetector_unittest.py

@@ -50 +50 @@
         detector = self._make_detector()
         detector._callstacks_to_exclude_from_leaks = lambda: ['foo bar', 'BAZ']
-        detector._types_to_exlude_from_leaks = lambda: ['abcdefg', 'hi jklmno']
+        detector._types_to_exclude_from_leaks = lambda: ['abcdefg', 'hi jklmno']
         expected_args = ['--exclude-callstack=foo bar', '--exclude-callstack=BAZ', '--exclude-type=abcdefg', '--exclude-type=hi jklmno', 1234]
         self.assertEqual(detector._leaks_args(1234), expected_args)