Changeset 225508 in webkit

Timestamp:

Dec 4, 2017 5:11:52 PM (6 years ago)

Author:

Brent Fulgham

Message:

Don't force creation of process pool when enabling resource load statistics
​https://bugs.webkit.org/show_bug.cgi?id=180374
<rdar://problem/35545639>

Reviewed by Alex Christensen.

Pass appropriate arguments to the 'processPool' accessor so that we only get the
set of existing process pools. We don't want to pay the cost of launching new
process pools just to set this flag. The flag will be properly set when the pools
are created as soon as a WebView is instantiated.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebsiteData/WebsiteDataStore.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-12-04  Brent Fulgham  <bfulgham@apple.com>
+
+        Don't force creation of process pool when enabling resource load statistics
+        https://bugs.webkit.org/show_bug.cgi?id=180374
+        <rdar://problem/35545639>
+
+        Reviewed by Alex Christensen.
+
+        Pass appropriate arguments to the 'processPool' accessor so that we only get the
+        set of existing process pools. We don't want to pay the cost of launching new
+        process pools just to set this flag. The flag will be properly set when the pools
+        are created as soon as a WebView is instantiated.
+
+        * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+        (WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
+
 2017-12-04  David Quesada  <david_quesada@apple.com>
 

trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp

@@ -1327 +1327 @@
 
     m_resourceLoadStatistics = nullptr;
-    for (auto& processPool : processPools())
+
+    auto existingProcessPools = processPools(std::numeric_limits<size_t>::max(), false);
+    for (auto& processPool : existingProcessPools)
         processPool->setResourceLoadStatisticsEnabled(false);
 }