Changeset 225602 in webkit

Timestamp:

Dec 6, 2017 4:02:55 PM (6 years ago)

Author:

webkit@devinrousso.com

Message:

Web Inspector: Canvas: spurious warnings shown for commands that changed pixel contents
​https://bugs.webkit.org/show_bug.cgi?id=180505
<rdar://problem/35891651>

Reviewed by Brian Burg.

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.apply.getContent):
(WI.RecordingAction.prototype.apply):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/RecordingAction.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-12-06  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: Canvas: spurious warnings shown for commands that changed pixel contents
+        https://bugs.webkit.org/show_bug.cgi?id=180505
+        <rdar://problem/35891651>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Models/RecordingAction.js:
+        (WI.RecordingAction.prototype.apply.getContent):
+        (WI.RecordingAction.prototype.apply):
+
 2017-12-06  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js

@@ -122 +122 @@
 
         function getContent() {
-            if (context instanceof CanvasRenderingContext2D)
-                return context.getImageData(0, 0, context.canvas.width, context.canvas.height);
+            if (context instanceof CanvasRenderingContext2D) {
+                let imageData = context.getImageData(0, 0, context.canvas.width, context.canvas.height);
+                return [imageData.width, imageData.height, ...imageData.data];
+            }
 
             if (context instanceof WebGLRenderingContext || context instanceof WebGL2RenderingContext) {
                 let pixels = new Uint8Array(context.drawingBufferWidth * context.drawingBufferHeight * 4);
                 context.readPixels(0, 0, context.canvas.width, context.canvas.height, context.RGBA, context.UNSIGNED_BYTE, pixels);
-                return pixels;
+                return [...pixels];
             }
 
@@ -155 +157 @@
 
             if (shouldCheckForChange) {
-                this._hasVisibleEffect = Array.shallowEqual(contentBefore, getContent());
+                this._hasVisibleEffect = !Array.shallowEqual(contentBefore, getContent());
                 if (!this._hasVisibleEffect)
                     this.dispatchEventToListeners(WI.RecordingAction.Event.HasVisibleEffectChanged);