Changeset 225654 in webkit


Ignore:
Timestamp:
Dec 7, 2017 4:22:55 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Fix style in remote inspector classes
​https://bugs.webkit.org/show_bug.cgi?id=180545

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-07
Reviewed by Youenn Fablet.

Source/JavaScriptCore:

  • inspector/remote/RemoteControllableTarget.h:
  • inspector/remote/RemoteInspectionTarget.h:
  • runtime/JSGlobalObjectDebuggable.h:

Source/WebCore:

  • page/PageDebuggable.h:
  • workers/service/context/ServiceWorkerDebuggable.h:
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r225652 r225654  
     12017-12-07  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Fix style in remote inspector classes
     4        https://bugs.webkit.org/show_bug.cgi?id=180545
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * inspector/remote/RemoteControllableTarget.h:
     9        * inspector/remote/RemoteInspectionTarget.h:
     10        * runtime/JSGlobalObjectDebuggable.h:
     11
    1122017-12-07  Per Arne Vollan  <pvollan@apple.com>
    213

  • trunk/Source/JavaScriptCore/inspector/remote/RemoteControllableTarget.h

    r224368 r225654  
    5959#if USE(CF)
    6060    // The dispatch block will be scheduled on a global run loop if null is returned.
    61     virtual CFRunLoopRef targetRunLoop() { return nullptr; }
     61    virtual CFRunLoopRef targetRunLoop() const { return nullptr; }
    6262#endif
     63
    6364private:
    64     unsigned m_identifier {0};
     65    unsigned m_identifier { 0 };
    6566};
    6667

  • trunk/Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h

    r224368 r225654  
    4343
    4444#if USE(CF)
    45     CFRunLoopRef targetRunLoop() override { return m_runLoop.get(); }
     45    CFRunLoopRef targetRunLoop() const final { return m_runLoop.get(); }
    4646    void setTargetRunLoop(CFRunLoopRef runLoop) { m_runLoop = runLoop; }
    4747#endif
    … …  
    5858
    5959    // RemoteControllableTarget overrides.
    60     bool remoteControlAllowed() const override;
     60    bool remoteControlAllowed() const final;
     61
    6162private:
    62     bool m_allowed {false};
     63    bool m_allowed { false };
    6364#if USE(CF)
    6465    RetainPtr<CFRunLoopRef> m_runLoop;

  • trunk/Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h

    r218794 r225654  
    4747    ~JSGlobalObjectDebuggable() { }
    4848
    49     Inspector::RemoteControllableTarget::Type type() const override { return Inspector::RemoteControllableTarget::Type::JavaScript; }
     49    Inspector::RemoteControllableTarget::Type type() const final { return Inspector::RemoteControllableTarget::Type::JavaScript; }
    5050
    51     String name() const override;
    52     bool hasLocalDebugger() const override { return false; }
     51    String name() const final;
     52    bool hasLocalDebugger() const final { return false; }
    5353
    54     void connect(Inspector::FrontendChannel*, bool isAutomaticConnection = false, bool immediatelyPause = false) override;
    55     void disconnect(Inspector::FrontendChannel*) override;
    56     void dispatchMessageFromRemote(const String& message) override;
     54    void connect(Inspector::FrontendChannel*, bool isAutomaticConnection = false, bool immediatelyPause = false) final;
     55    void disconnect(Inspector::FrontendChannel*) final;
     56    void dispatchMessageFromRemote(const String& message) final;
    5757
    58     bool automaticInspectionAllowed() const override { return true; }
    59     void pauseWaitingForAutomaticInspection() override;
     58    bool automaticInspectionAllowed() const final { return true; }
     59    void pauseWaitingForAutomaticInspection() final;
    6060
    6161private:

  • trunk/Source/WebCore/ChangeLog

    r225650 r225654  
     12017-12-07  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Fix style in remote inspector classes
     4        https://bugs.webkit.org/show_bug.cgi?id=180545
     5
     6        Reviewed by Youenn Fablet.
     7
     8        * page/PageDebuggable.h:
     9        * workers/service/context/ServiceWorkerDebuggable.h:
     10
    1112017-12-07  Antti Koivisto  <antti@apple.com>
    212

  • trunk/Source/WebCore/page/PageDebuggable.h

    r224148 r225654  
    4242    ~PageDebuggable() = default;
    4343
    44     Inspector::RemoteControllableTarget::Type type() const override { return Inspector::RemoteControllableTarget::Type::Web; }
     44    Inspector::RemoteControllableTarget::Type type() const final { return Inspector::RemoteControllableTarget::Type::Web; }
    4545
    46     String name() const override;
    47     String url() const override;
    48     bool hasLocalDebugger() const override;
     46    String name() const final;
     47    String url() const final;
     48    bool hasLocalDebugger() const final;
    4949
    50     void connect(Inspector::FrontendChannel*, bool isAutomaticConnection = false, bool immediatelyPause = false) override;
    51     void disconnect(Inspector::FrontendChannel*) override;
    52     void dispatchMessageFromRemote(const String& message) override;
    53     void setIndicating(bool) override;
     50    void connect(Inspector::FrontendChannel*, bool isAutomaticConnection = false, bool immediatelyPause = false) final;
     51    void disconnect(Inspector::FrontendChannel*) final;
     52    void dispatchMessageFromRemote(const String& message) final;
     53    void setIndicating(bool) final;
    5454
    55     String nameOverride() const { return m_nameOverride; }
     55    const String& nameOverride() const { return m_nameOverride; }
    5656    void setNameOverride(const String&);
    5757

  • trunk/Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h

    r225633 r225654  
    4444    ~ServiceWorkerDebuggable() = default;
    4545
    46     Inspector::RemoteControllableTarget::Type type() const override { return Inspector::RemoteControllableTarget::Type::ServiceWorker; }
     46    Inspector::RemoteControllableTarget::Type type() const final { return Inspector::RemoteControllableTarget::Type::ServiceWorker; }
    4747
    48     String name() const override { return ASCIILiteral("ServiceWorker"); }
    49     String url() const override { return m_scopeURL; }
    50     bool hasLocalDebugger() const override { return false; }
     48    String name() const final { return ASCIILiteral("ServiceWorker"); }
     49    String url() const final { return m_scopeURL; }
     50    bool hasLocalDebugger() const final { return false; }
    5151
    52     void connect(Inspector::FrontendChannel*, bool isAutomaticConnection = false, bool immediatelyPause = false) override;
    53     void disconnect(Inspector::FrontendChannel*) override;
    54     void dispatchMessageFromRemote(const String& message) override;
     52    void connect(Inspector::FrontendChannel*, bool isAutomaticConnection = false, bool immediatelyPause = false) final;
     53    void disconnect(Inspector::FrontendChannel*) final;
     54    void dispatchMessageFromRemote(const String& message) final;
    5555
    5656private:
Note: See TracChangeset for help on using the changeset viewer.