Changeset 225731 in webkit

Timestamp:

Dec 10, 2017 5:14:27 AM (6 years ago)

Author:

Yusuke Suzuki

Message:

Unreviewed, follow-up patch after r225470
​https://bugs.webkit.org/show_bug.cgi?id=180308

• Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
Use consistent operands.

• bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):
Use class field initializer.

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):
Use consistent operands.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webdatabase/SQLTransaction.cpp (modified) (1 diff)
• bindings/js/JSCallbackData.h (modified) (2 diffs)
• xml/parser/XMLDocumentParserLibxml2.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-10  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        Unreviewed, follow-up patch after r225470
+        https://bugs.webkit.org/show_bug.cgi?id=180308
+
+        * Modules/webdatabase/SQLTransaction.cpp:
+        (WebCore::SQLTransaction::checkAndHandleClosedDatabase):
+        Use consistent operands.
+
+        * bindings/js/JSCallbackData.h:
+        (WebCore::JSCallbackData::JSCallbackData):
+        Use class field initializer.
+
+        * xml/parser/XMLDocumentParserLibxml2.cpp:
+        (WebCore::openFunc):
+        Use consistent operands.
+
 2017-12-09  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.cpp

@@ -185 +185 @@
 
     // The next steps should be executed only if we're on the DB thread.
-    if (&Thread::current() != m_database->databaseThread().getThread())
+    if (m_database->databaseThread().getThread() != &Thread::current())
         return;
 

trunk/Source/WebCore/bindings/js/JSCallbackData.h

@@ -52 +52 @@
     explicit JSCallbackData(JSDOMGlobalObject* globalObject)
         : m_globalObject(globalObject)
-#ifndef NDEBUG
-        , m_thread(Thread::current())
-#endif
     {
     }
@@ -70 +67 @@
     JSC::Weak<JSDOMGlobalObject> m_globalObject;
 #ifndef NDEBUG
-    Ref<Thread> m_thread;
+    Ref<Thread> m_thread { Thread::current() };
 #endif
 };

trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp

@@ -432 +432 @@
 {
     ASSERT(XMLDocumentParserScope::currentCachedResourceLoader);
-    ASSERT(&Thread::current() == libxmlLoaderThread);
+    ASSERT(libxmlLoaderThread == &Thread::current());
 
     URL url(URL(), uri);