Changeset 225785 in webkit

Timestamp:

Dec 12, 2017 9:26:34 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Allow AudioContext to start when getUserMedia is on
​https://bugs.webkit.org/show_bug.cgi?id=180680

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-12
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/getUserMedia-webaudio-autoplay.html

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::willBeginPlayback):

LayoutTests:

• webrtc/getUserMedia-webaudio-autoplay-expected.txt: Added.
• webrtc/getUserMedia-webaudio-autoplay.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webrtc/getUserMedia-webaudio-autoplay-expected.txt (added)
• LayoutTests/webrtc/getUserMedia-webaudio-autoplay.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/AudioContext.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-12-12  Youenn Fablet  <youenn@apple.com>
+
+        Allow AudioContext to start when getUserMedia is on
+        https://bugs.webkit.org/show_bug.cgi?id=180680
+
+        Reviewed by Eric Carlson.
+
+        * webrtc/getUserMedia-webaudio-autoplay-expected.txt: Added.
+        * webrtc/getUserMedia-webaudio-autoplay.html: Added.
+
 2017-12-12  Ms2ger  <Ms2ger@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-12  Youenn Fablet  <youenn@apple.com>
+
+        Allow AudioContext to start when getUserMedia is on
+        https://bugs.webkit.org/show_bug.cgi?id=180680
+
+        Reviewed by Eric Carlson.
+
+        Test: webrtc/getUserMedia-webaudio-autoplay.html
+
+        * Modules/webaudio/AudioContext.cpp:
+        (WebCore::AudioContext::willBeginPlayback):
+
 2017-12-12  Romain Bellessort  <romain.bellessort@crf.canon.fr>
 

trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp

@@ -985 +985 @@
 {
     if (userGestureRequiredForAudioStart()) {
-        if (!processingUserGestureForMedia())
+        if (!processingUserGestureForMedia() && !document()->isCapturing())
             return false;
         removeBehaviorRestriction(AudioContext::RequireUserGestureForAudioStartRestriction);