Changeset 225853 in webkit
- Timestamp:
- Dec 13, 2017 10:35:14 AM (6 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r225850 r225853 1 2017-12-13 Daniel Bates <dabates@apple.com> 2 3 Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list 4 https://bugs.webkit.org/show_bug.cgi?id=180754 5 6 Reviewed by Wenson Hsieh. 7 8 Group all in-parameters in the signature of API::FormClient::willBeginInputSession() at 9 the front of the parameter list instead of interspersing in- and out- parameters. 10 11 No functionality changed. So, no new tests. 12 13 * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: 14 (-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): 15 * WebProcess/InjectedBundle/APIInjectedBundleFormClient.h: 16 (API::InjectedBundle::FormClient::willBeginInputSession): 17 * WebProcess/WebPage/WebPage.cpp: 18 (WebKit::WebPage::elementDidFocus): 19 1 20 2017-12-13 Chris Dumez <cdumez@apple.com> 2 21 -
trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
r225309 r225853 529 529 } 530 530 531 void willBeginInputSession(WebPage*, Element* element, WebFrame* frame, RefPtr<API::Object>& userData, bool userIsInteracting) override531 void willBeginInputSession(WebPage*, Element* element, WebFrame* frame, bool userIsInteracting, RefPtr<API::Object>& userData) override 532 532 { 533 533 auto formDelegate = m_controller->_formDelegate.get(); -
trunk/Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h
r222113 r225853 72 72 virtual void didAssociateFormControls(WebKit::WebPage*, const Vector<RefPtr<WebCore::Element>>&) { } 73 73 virtual bool shouldNotifyOnFormChanges(WebKit::WebPage*) { return false; } 74 virtual void willBeginInputSession(WebKit::WebPage*, WebCore::Element*, WebKit::WebFrame*, RefPtr<API::Object>& userData, bool userIsInteracting) { UNUSED_PARAM(userData); }74 virtual void willBeginInputSession(WebKit::WebPage*, WebCore::Element*, WebKit::WebFrame*, bool userIsInteracting, RefPtr<API::Object>& userData) { UNUSED_PARAM(userData); } 75 75 }; 76 76 -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
r225827 r225853 4858 4858 RefPtr<API::Object> userData; 4859 4859 4860 m_formClient->willBeginInputSession(this, downcast<Element>(node), WebFrame::fromCoreFrame(*node->document().frame()), userData, m_userIsInteracting);4860 m_formClient->willBeginInputSession(this, downcast<Element>(node), WebFrame::fromCoreFrame(*node->document().frame()), m_userIsInteracting, userData); 4861 4861 4862 4862 send(Messages::WebPageProxy::StartAssistingNode(information, m_userIsInteracting, m_hasPendingBlurNotification, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())));
Note: See TracChangeset
for help on using the changeset viewer.