Changeset 225853 in webkit


Ignore:
Timestamp:
Dec 13, 2017 10:35:14 AM (6 years ago)
Author:
dbates@webkit.org
Message:

Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list
https://bugs.webkit.org/show_bug.cgi?id=180754

Reviewed by Wenson Hsieh.

Group all in-parameters in the signature of API::FormClient::willBeginInputSession() at
the front of the parameter list instead of interspersing in- and out- parameters.

No functionality changed. So, no new tests.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

  • WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:

(API::InjectedBundle::FormClient::willBeginInputSession):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::elementDidFocus):

Location:
trunk/Source/WebKit
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r225850 r225853  
     12017-12-13  Daniel Bates  <dabates@apple.com>
     2
     3        Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list
     4        https://bugs.webkit.org/show_bug.cgi?id=180754
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        Group all in-parameters in the signature of API::FormClient::willBeginInputSession() at
     9        the front of the parameter list instead of interspersing in- and out- parameters.
     10
     11        No functionality changed. So, no new tests.
     12
     13        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
     14        (-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
     15        * WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:
     16        (API::InjectedBundle::FormClient::willBeginInputSession):
     17        * WebProcess/WebPage/WebPage.cpp:
     18        (WebKit::WebPage::elementDidFocus):
     19
    1202017-12-13  Chris Dumez  <cdumez@apple.com>
    221
  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm

    r225309 r225853  
    529529        }
    530530
    531         void willBeginInputSession(WebPage*, Element* element, WebFrame* frame, RefPtr<API::Object>& userData, bool userIsInteracting) override
     531        void willBeginInputSession(WebPage*, Element* element, WebFrame* frame, bool userIsInteracting, RefPtr<API::Object>& userData) override
    532532        {
    533533            auto formDelegate = m_controller->_formDelegate.get();
  • trunk/Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h

    r222113 r225853  
    7272    virtual void didAssociateFormControls(WebKit::WebPage*, const Vector<RefPtr<WebCore::Element>>&) { }
    7373    virtual bool shouldNotifyOnFormChanges(WebKit::WebPage*) { return false; }
    74     virtual void willBeginInputSession(WebKit::WebPage*, WebCore::Element*, WebKit::WebFrame*, RefPtr<API::Object>& userData, bool userIsInteracting) { UNUSED_PARAM(userData); }
     74    virtual void willBeginInputSession(WebKit::WebPage*, WebCore::Element*, WebKit::WebFrame*, bool userIsInteracting, RefPtr<API::Object>& userData) { UNUSED_PARAM(userData); }
    7575};
    7676
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r225827 r225853  
    48584858        RefPtr<API::Object> userData;
    48594859
    4860         m_formClient->willBeginInputSession(this, downcast<Element>(node), WebFrame::fromCoreFrame(*node->document().frame()), userData, m_userIsInteracting);
     4860        m_formClient->willBeginInputSession(this, downcast<Element>(node), WebFrame::fromCoreFrame(*node->document().frame()), m_userIsInteracting, userData);
    48614861
    48624862        send(Messages::WebPageProxy::StartAssistingNode(information, m_userIsInteracting, m_hasPendingBlurNotification, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())));
Note: See TracChangeset for help on using the changeset viewer.