Changeset 226207 in webkit

Timestamp:

Dec 20, 2017 5:49:00 PM (6 years ago)

Author:

Matt Lewis

Message:

Unreviewed, rolling out r226155.

This caused test failures.

Reverted changeset:

"Web Inspector: add TestPage.debug() to inspect evaluations
being sent to Inspector page"
​https://bugs.webkit.org/show_bug.cgi?id=181005
​https://trac.webkit.org/changeset/226155

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/inspector/resources/inspector-test.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-12-20  Matt Lewis  <jlewis3@apple.com>
+
+        Unreviewed, rolling out r226155.
+
+        This caused test failures.
+
+        Reverted changeset:
+
+        "Web Inspector: add TestPage.debug() to inspect evaluations
+        being sent to Inspector page"
+        https://bugs.webkit.org/show_bug.cgi?id=181005
+        https://trac.webkit.org/changeset/226155
+
 2017-12-20  Brady Eidson  <beidson@apple.com>
 

trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js

@@ -98 +98 @@
     let testFunctionCodeString = `(${runTestMethodInFrontend.toString()})(${testFunction.toString()});`;
 
-    TestPage.evaluateInWebInspector(initializationCodeString);
-    TestPage.evaluateInWebInspector(testFunctionCodeString);
+    testRunner.evaluateInWebInspector(initializationCodeString);
+    testRunner.evaluateInWebInspector(testFunctionCodeString);
 }
 
@@ -140 +140 @@
 }
 
-// Use this to dump evaluations that are sent from the TestPage to the InspectorTest page.
-TestPage.debug = function()
-{
-    this.dumpInspectorPageEvaluations = true;
-}
-
-TestPage.evaluateInWebInspector = function(code)
-{
-    if (this.dumpInspectorPageEvaluations)
-        this.debugLog(code);
-
-    testRunner.evaluateInWebInspector(code);
-}
-
 // Add and clear test output from the results window.
 TestPage.addResult = function(text)
@@ -177 +163 @@
 {
     let dispatchEventCodeString = `InspectorTest.dispatchEventToListeners(${JSON.stringify(eventName)}, ${JSON.stringify(data)});`;
-    this.evaluateInWebInspector(dispatchEventCodeString);
+    testRunner.evaluateInWebInspector(dispatchEventCodeString);
 };