Changeset 226210 in webkit


Ignore:
Timestamp:
Dec 20, 2017 6:38:00 PM (6 years ago)
Author:
Matt Lewis
Message:

Unreviewed, rolling out r225656.

The test has been a flaky timout since being added.

Reverted changeset:

"WebAssembly: sending module to iframe fails"
https://bugs.webkit.org/show_bug.cgi?id=179263
https://trac.webkit.org/changeset/225656

Location:
trunk
Files:
1 deleted
8 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r226207 r226210  
     12017-12-20  Matt Lewis  <jlewis3@apple.com>
     2
     3        Unreviewed, rolling out r225656.
     4
     5        The test has been a flaky timout since being added.
     6
     7        Reverted changeset:
     8
     9        "WebAssembly: sending module to iframe fails"
     10        https://bugs.webkit.org/show_bug.cgi?id=179263
     11        https://trac.webkit.org/changeset/225656
     12
    1132017-12-20  Matt Lewis  <jlewis3@apple.com>
    214
  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r225656 r226210  
    5353http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ]
    5454http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ]
    55 wasm/iframe-postmessage.html [ Skip ]
    56 wasm/iframe-parent-postmessage.html [ Skip ]
    57 wasm/window-postmessage.html [ Skip ]
    5855
    5956# WebGL tests which need triaging https://bugs.webkit.org/b/174100
  • trunk/LayoutTests/platform/win/TestExpectations

    r225656 r226210  
    36743674workers/wasm-long-compile.html [ Skip ]
    36753675workers/wasm-mem-post-message.html [ Skip ]
    3676 wasm/iframe-postmessage.html [ Skip ]
    3677 wasm/iframe-parent-postmessage.html [ Skip ]
    3678 wasm/window-postmessage.html [ Skip ]
    36793676
    36803677# Animated image throttling behaves differently on WK1.
  • trunk/LayoutTests/workers/wasm-mem-post-message.html

    r225656 r226210  
    11<html>
    22  <head>
    3     <script src="../resources/wasm-builder.js"></script>
     3    <script src="./wasm-resources/builder.js"></script>
    44    <script src="../resources/js-test-pre.js"></script>
    55</head>
  • trunk/Source/WebCore/ChangeLog

    r226205 r226210  
     12017-12-20  Matt Lewis  <jlewis3@apple.com>
     2
     3        Unreviewed, rolling out r225656.
     4
     5        The test has been a flaky timout since being added.
     6
     7        Reverted changeset:
     8
     9        "WebAssembly: sending module to iframe fails"
     10        https://bugs.webkit.org/show_bug.cgi?id=179263
     11        https://trac.webkit.org/changeset/225656
     12
    1132017-12-20  Don Olmstead  <don.olmstead@sony.com>
    214
  • trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp

    r225656 r226210  
    10671067#if ENABLE(WEBASSEMBLY)
    10681068            if (JSWebAssemblyModule* module = jsDynamicDowncast<JSWebAssemblyModule*>(vm, obj)) {
    1069                 if (m_context != SerializationContext::WorkerPostMessage && m_context != SerializationContext::WindowPostMessage)
     1069                if (m_context != SerializationContext::WorkerPostMessage)
    10701070                    return false;
    10711071
  • trunk/Source/WebCore/bindings/js/SerializedScriptValue.h

    r225656 r226210  
    5252
    5353enum class SerializationErrorMode { NonThrowing, Throwing };
    54 enum class SerializationContext { Default, WorkerPostMessage, WindowPostMessage };
     54enum class SerializationContext { Default, WorkerPostMessage };
    5555
    5656using ArrayBufferContentsArray = Vector<JSC::ArrayBufferContents>;
  • trunk/Source/WebCore/page/DOMWindow.cpp

    r225791 r226210  
    928928
    929929    Vector<RefPtr<MessagePort>> ports;
    930     auto message = SerializedScriptValue::create(state, messageValue, WTFMove(transfer), ports, SerializationContext::WindowPostMessage);
     930    auto message = SerializedScriptValue::create(state, messageValue, WTFMove(transfer), ports);
    931931    if (message.hasException())
    932932        return message.releaseException();
Note: See TracChangeset for help on using the changeset viewer.