Changeset 226294 in webkit

Timestamp:

Dec 26, 2017 10:54:38 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r226269): 60 JSC test failures on ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=181163

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2017-12-26
Reviewed by Yusuke Suzuki.

In r226269, DFG::SpeculativeJIT::compile() changed behavior for the
GetDirectPname operation on non-x86 platforms, switching to using
GPRFlushedCallResult registers for the payload and tag pair of the
return value (through the JSValueRegsFlushedCallResult struct). This
tripped about 60 test cases on ARMv7.

As before this change, GPRTemporary registers should be used, but this
can now be done through a JSValueRegsTemporary object.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT32_64.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-12-26  Zan Dobersek  <zdobersek@igalia.com>
+
+        REGRESSION(r226269): 60 JSC test failures on ARMv7
+        https://bugs.webkit.org/show_bug.cgi?id=181163
+
+        Reviewed by Yusuke Suzuki.
+
+        In r226269, DFG::SpeculativeJIT::compile() changed behavior for the
+        GetDirectPname operation on non-x86 platforms, switching to using
+        GPRFlushedCallResult registers for the payload and tag pair of the
+        return value (through the JSValueRegsFlushedCallResult struct). This
+        tripped about 60 test cases on ARMv7.
+
+        As before this change, GPRTemporary registers should be used, but this
+        can now be done through a JSValueRegsTemporary object.
+
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        (JSC::DFG::SpeculativeJIT::compile):
+
 2017-12-22  Caio Lima  <ticaiolima@gmail.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

@@ -4894 +4894 @@
 #else
         GPRTemporary scratch(this);
-        JSValueRegsFlushedCallResult result(this);
+        JSValueRegsTemporary result(this);
 
         GPRReg scratchGPR = scratch.gpr();