Changeset 226376 in webkit

Timestamp:

Jan 3, 2018 4:32:37 PM (6 years ago)

Author:

Michael Catanzaro

Message:

REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
​https://bugs.webkit.org/show_bug.cgi?id=173915

Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
/webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
empty string in this case.

• TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(emitFormSubmissionEvent):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
+        https://bugs.webkit.org/show_bug.cgi?id=173915
+
+        Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
+        /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
+        GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
+        empty string in this case.
+
+        * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
+        (emitFormSubmissionEvent):
+
 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp

@@ -350 +350 @@
         "org.webkit.gtk.WebExtensionTest",
         methodName,
-        g_variant_new("(sssbb)", formID, names, values, targetFrameIsMainFrame, sourceFrameIsMainFrame),
+        g_variant_new("(sssbb)", formID ? formID : "", names, values, targetFrameIsMainFrame, sourceFrameIsMainFrame),
         nullptr);
     g_assert(ok);