Changeset 226378 in webkit

Timestamp:

Jan 3, 2018 4:42:21 PM (6 years ago)

Author:

Simon Fraser

Message:

filter-build-webkit filters out useful compiler error lines
​https://bugs.webkit.org/show_bug.cgi?id=179864

Reviewed by Tim Horton.

Don't filter out lines that contain information about build errors by always showing lines
after a line that contains "note:" or "error:".

• Scripts/filter-build-webkit:

(shouldShowSubsequentLine):
(shouldIgnoreLine):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/filter-build-webkit (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-01-03  Simon Fraser  <simon.fraser@apple.com>
+
+        filter-build-webkit filters out useful compiler error lines
+        https://bugs.webkit.org/show_bug.cgi?id=179864
+
+        Reviewed by Tim Horton.
+
+        Don't filter out lines that contain information about build errors by always showing lines
+        after a line that contains "note:" or "error:".
+
+        * Scripts/filter-build-webkit:
+        (shouldShowSubsequentLine):
+        (shouldIgnoreLine):
+
 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Tools/Scripts/filter-build-webkit

@@ -230 +230 @@
 }
 
+sub shouldShowSubsequentLine($)
+{
+    my ($line) = @_;
+
+    return 1 if $line =~ /referenced from:$/;
+    return 1 if $line =~ /(note:|error:)/;
+    
+    return 0;
+}
+
 sub shouldIgnoreLine($$)
 {
@@ -282 +292 @@
     } else {
         return 1 if $line =~ /^(touch|perl|cat|rm -f|bison|flex|python|\/usr\/bin\/g\+\+|\/bin\/ln|gperf|echo|sed|if \[ \-f|WebCore\/generate-export-file|write-file|chmod) /;
-        return 1 if $line =~ /^    / && $previousLine !~ /referenced from:$/;
+        return 1 if $line =~ /^    / && !shouldShowSubsequentLine($previousLine);
         return 1 if $line =~ /^printf /;
         return 1 if $line =~ /^offlineasm: Nothing changed/;