Changeset 226722 in webkit


Ignore:
Timestamp:
Jan 10, 2018 10:20:30 AM (6 years ago)
Author:
Chris Dumez
Message:

REGRESSION (r224301?): LayoutTest http/tests/workers/service/registration-task-queue-scheduling-1.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=179342
<rdar://problem/35478161>

Reviewed by Youenn Fablet.

Unmark the test as flaky.

  • http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
  • http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html:
  • http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:

Update test to register a scriptURL that actually fails. When registration succeeds, the test
logs lines indicating that registration succeeded unexpectedly. Also, when registration
succeeds, the registration of the top frame are no longer guaranteed to be resolved before
the ones of the subframe (because it involves things like network loads).

Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r226720 r226722  
     12018-01-10  Chris Dumez  <cdumez@apple.com>
     2
     3        REGRESSION (r224301?): LayoutTest http/tests/workers/service/registration-task-queue-scheduling-1.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=179342
     5        <rdar://problem/35478161>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        * TestExpectations:
     10        Unmark the test as flaky.
     11
     12        * http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
     13        * http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html:
     14        * http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:
     15        Update test to register a scriptURL that actually fails. When registration succeeds, the test
     16        logs lines indicating that registration succeeded unexpectedly. Also, when registration
     17        succeeds, the registration of the top frame are no longer guaranteed to be resolved before
     18        the ones of the subframe (because it involves things like network loads).
     19
    1202018-01-10  Chris Dumez  <cdumez@apple.com>
    221

  • trunk/LayoutTests/TestExpectations

    r226720 r226722  
    165165imported/w3c/web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https.html [ Skip ]
    166166
    167 webkit.org/b/179342 http/tests/workers/service/registration-task-queue-scheduling-1.html [ Pass Failure ]
    168167imported/w3c/web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html [ Pass Failure ]
    169168webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ]

  • trunk/LayoutTests/http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt

    r223608 r226722  
    1 CONSOLE MESSAGE: line 48: Original window resolved successfully (unexpected)
     1ALERT: PASS
    22

  • trunk/LayoutTests/http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html

    r221198 r226722  
    55
    66for (var i = 0; i < 1000; ++i) {
    7         navigator.serviceWorker.register("empty-worker.js", { })
     7        navigator.serviceWorker.register("http://127.0.0.1:8000/workers/service/resources/empty-worker.js", { })
    88        .then(function(r) {
    99                alert("Popup window resolved successfully (unexpected)")

  • trunk/LayoutTests/http/tests/workers/service/resources/registration-task-queue-scheduling-1.js

    r223608 r226722  
    3838                alert("Popup should not have popped up before this main window");
    3939        else
    40                 alert("Done");
     40                alert("PASS");
    4141       
    4242        finishSWTest();
    … …  
    4444
    4545for (var i = 0; i < 1000; ++i) {
    46         navigator.serviceWorker.register("resources/empty-worker.js", { })
     46        navigator.serviceWorker.register("http://localhost:8000/workers/service/resources/empty-worker.js", { })
    4747        .then(function(r) {
    4848                console.log("Original window resolved successfully (unexpected)")
    4949                finishSWTest();
    5050        }, function(e) {
    51                 if (e+"" != "UnknownError: Script URL http://127.0.0.1:8000/workers/service/resources/empty-worker.js fetched with 41 characters, but we're not using the result yet") {
     51                if (e.name != "SecurityError") {
    5252                        alert("Unexpected error received from server: " + e);
    5353                        finishSWTest();
    5454                }
    55                
    5655                responded();
    5756        })
Note: See TracChangeset for help on using the changeset viewer.