Changeset 227008 in webkit
- Timestamp:
- Jan 16, 2018 3:17:36 PM (6 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r227003 r227008 1 2018-01-16 Matt Baker <mattbaker@apple.com> 2 3 Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't trigger a recording 4 https://bugs.webkit.org/show_bug.cgi?id=181706 5 <rdar://problem/36558221> 6 7 Reviewed by Joseph Pecoraro. 8 9 * UserInterface/Views/CanvasOverviewContentView.js: 10 (WI.CanvasOverviewContentView): 11 (WI.CanvasOverviewContentView.prototype._handleSpace): 12 1 13 2018-01-16 Joseph Pecoraro <pecoraro@apple.com> 2 14 -
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js
r225587 r227008 62 62 new WI.KeyboardShortcut(null, WI.KeyboardShortcut.Key.Down, this._handleDown.bind(this)), 63 63 new WI.KeyboardShortcut(null, WI.KeyboardShortcut.Key.Left, this._handleLeft.bind(this)), 64 new WI.KeyboardShortcut(null, WI.KeyboardShortcut.Key.Space, this._handleSpace.bind(this)),65 new WI.KeyboardShortcut(WI.KeyboardShortcut.Modifier.Shift, WI.KeyboardShortcut.Key.Space, this._handleSpace.bind(this)),66 64 ]; 65 66 let recordShortcut = new WI.KeyboardShortcut(null, WI.KeyboardShortcut.Key.Space, this._handleSpace.bind(this)); 67 recordShortcut.implicitlyPreventsDefault = false; 68 this._keyboardShortcuts.push(recordShortcut); 69 70 let recordSingleFrameShortcut = new WI.KeyboardShortcut(WI.KeyboardShortcut.Modifier.Shift, WI.KeyboardShortcut.Key.Space, this._handleSpace.bind(this)); 71 recordSingleFrameShortcut.implicitlyPreventsDefault = false; 72 this._keyboardShortcuts.push(recordSingleFrameShortcut); 67 73 68 74 for (let shortcut of this._keyboardShortcuts) … … 242 248 _handleSpace(event) 243 249 { 250 if (WI.isEventTargetAnEditableField(event)) 251 return; 252 244 253 if (!this._selectedItem) 245 254 return; … … 251 260 WI.canvasManager.startRecording(this._selectedItem, singleFrame); 252 261 } 262 263 event.preventDefault(); 253 264 } 254 265
Note: See TracChangeset
for help on using the changeset viewer.