Changeset 227151 in webkit


Ignore:
Timestamp:
Jan 18, 2018 10:38:15 AM (6 years ago)
Author:
jdiggs@igalia.com
Message:

[GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
​https://bugs.webkit.org/show_bug.cgi?id=176796

Reviewed by Chris Fleizach.

Tools:

Add sanity check that we have a URL before calling g_strstr_len().

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::url):

LayoutTests:

Remove failing tests from Test Expectations. Update expected results of
xml-roles-exposed to reflect several bug fixes which were made in the
interim. Modify add-children-pseudo-element.html to account for platform
differences in the accessibility tree. Add an additional URL test because
we didn't have coverage for getting the URL of accessible links resulting
from native anchor elements.

  • accessibility/add-children-pseudo-element.html: Modified.
  • accessibility/gtk/link-url-expected.txt: Added.
  • accessibility/gtk/link-url.html: Added.
  • accessibility/gtk/xml-roles-exposed-expected.txt: Updated.
  • platform/gtk/TestExpectations: Removed failing tests.
  • platform/gtk/accessibility/add-children-pseudo-element-expected.txt: Added.
Location:
trunk
Files:
3 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r227148 r227151  
     12018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
     4        https://bugs.webkit.org/show_bug.cgi?id=176796
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Remove failing tests from Test Expectations. Update expected results of
     9        xml-roles-exposed to reflect several bug fixes which were made in the
     10        interim. Modify add-children-pseudo-element.html to account for platform
     11        differences in the accessibility tree. Add an additional URL test because
     12        we didn't have coverage for getting the URL of accessible links resulting
     13        from native anchor elements.
     14
     15        * accessibility/add-children-pseudo-element.html: Modified.
     16        * accessibility/gtk/link-url-expected.txt: Added.
     17        * accessibility/gtk/link-url.html: Added.
     18        * accessibility/gtk/xml-roles-exposed-expected.txt: Updated.
     19        * platform/gtk/TestExpectations: Removed failing tests.
     20        * platform/gtk/accessibility/add-children-pseudo-element-expected.txt: Added.
     21
    1222018-01-18  Matt Lewis  <jlewis3@apple.com>
    223

  • trunk/LayoutTests/accessibility/add-children-pseudo-element.html

    r220551 r227151  
    4444    if (window.accessibilityController) {
    4545        var element = accessibilityController.accessibleElementById("float");
    46         shouldBe("element.childrenCount", "3");
     46        if (accessibilityController.platformName != "atk")
     47            shouldBe("element.childrenCount", "3");
     48        else
     49            shouldBe("element.childrenCount", "2");
    4750       
    4851        eventSender.keyDown('\t');
    4952        eventSender.keyDown('\t');
    5053       
    51         shouldBe("element.childrenCount", "2");
     54        if (accessibilityController.platformName != "atk")
     55            shouldBe("element.childrenCount", "2");
     56        else
     57            shouldBe("element.childrenCount", "1");
    5258        showPseudo();
    5359       

  • trunk/LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt

    r221671 r227151  
    2121AXRequired: 0
    2222AXChecked: 0
    23 AXPlatformAttributes: computed-role:alert, xml-roles:alert, tag:div, toolkit:WebKitGtk
     23AXPlatformAttributes: atomic:true, relevant:additions text, live:assertive, container-live-role:alert, container-atomic:true, container-relevant:additions text, container-live:assertive, computed-role:alert, xml-roles:alert, tag:div, toolkit:WebKitGtk
    2424------------
    2525AXRole: AXDialog
    … …  
    4040AXRequired: 0
    4141AXChecked: 0
    42 AXPlatformAttributes: computed-role:alertdialog, xml-roles:alertdialog, tag:div, toolkit:WebKitGtk
     42AXPlatformAttributes: relevant:additions text, live:assertive, container-live-role:alertdialog, container-relevant:additions text, container-live:assertive, computed-role:alertdialog, xml-roles:alertdialog, tag:div, toolkit:WebKitGtk
    4343------------
    4444AXRole: AXEmbedded
    … …  
    308308AXPlatformAttributes: computed-role:figure, xml-roles:figure, tag:div, toolkit:WebKitGtk
    309309------------
    310 AXRole: AXForm
     310AXRole: AXLandmarkForm
    311311AXParent: AXWebArea
    312312AXChildren: 0
    … …  
    421421AXRequired: 0
    422422AXChecked: 0
    423 AXPlatformAttributes: computed-role:log, xml-roles:log, tag:div, toolkit:WebKitGtk
     423AXPlatformAttributes: relevant:additions text, live:polite, container-live-role:log, container-relevant:additions text, container-live:polite, computed-role:log, xml-roles:log, tag:div, toolkit:WebKitGtk
    424424------------
    425425AXRole: AXLandmarkMain
    … …  
    459459AXRequired: 0
    460460AXChecked: 0
    461 AXPlatformAttributes: computed-role:marquee, xml-roles:marquee, tag:div, toolkit:WebKitGtk
     461AXPlatformAttributes: relevant:additions text, live:off, container-live-role:marquee, container-relevant:additions text, container-live:off, computed-role:marquee, xml-roles:marquee, tag:div, toolkit:WebKitGtk
    462462------------
    463463AXRole: AXMath
    … …  
    725725AXRequired: 0
    726726AXChecked: 0
    727 AXPlatformAttributes: computed-role:status, xml-roles:status, tag:div, toolkit:WebKitGtk
     727AXPlatformAttributes: atomic:true, relevant:additions text, live:polite, container-live-role:status, container-atomic:true, container-relevant:additions text, container-live:polite, computed-role:status, xml-roles:status, tag:div, toolkit:WebKitGtk
    728728------------
    729729AXRole: AXToggleButton
    … …  
    801801AXRequired: 0
    802802AXChecked: 0
    803 AXPlatformAttributes: computed-role:timer, xml-roles:timer, tag:div, toolkit:WebKitGtk
     803AXPlatformAttributes: relevant:additions text, live:off, container-live-role:timer, container-relevant:additions text, container-live:off, computed-role:timer, xml-roles:timer, tag:div, toolkit:WebKitGtk
    804804------------
    805805AXRole: AXToolbar

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r227097 r227151  
    12921292webkit.org/b/175575 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html [ Crash Pass ]
    12931293
    1294 webkit.org/b/176796 accessibility/gtk/xml-roles-exposed.html [ Crash ]
    1295 
    12961294webkit.org/b/176797 accessibility/aria-listbox-no-selection.html [ Crash ]
    12971295
    … …  
    31983196webkit.org/b/175134 fast/text/line-height-minimumFontSize-zoom.html [ ImageOnlyFailure ]
    31993197
    3200 # Crash is webkit.org/b/176796
    3201 webkit.org/b/175418 accessibility/add-children-pseudo-element.html [ Failure Crash ]
    3202 
    32033198webkit.org/b/175420 fullscreen/requestFullscreen-escape-key.html [ Failure ]
    32043199

  • trunk/Tools/ChangeLog

    r227150 r227151  
     12018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
     4        https://bugs.webkit.org/show_bug.cgi?id=176796
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Add sanity check that we have a URL before calling g_strstr_len().
     9
     10        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
     11        (WTR::AccessibilityUIElement::url):
     12
    1132018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
    214

  • trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

    r226432 r227151  
    20332033    GUniquePtr<char> hyperlinkURI(atk_hyperlink_get_uri(hyperlink, 0));
    20342034
     2035    if (!hyperlinkURI.get())
     2036        return JSStringCreateWithUTF8CString("AXURL: (null)");
     2037
    20352038    // Build the result string, stripping the absolute URL paths if present.
    20362039    char* localURI = g_strstr_len(hyperlinkURI.get(), -1, "LayoutTests");
Note: See TracChangeset for help on using the changeset viewer.