Changeset 227243 in webkit

Timestamp:

Jan 19, 2018 3:01:11 PM (6 years ago)

Author:

Matt Baker

Message:

Web Inspector: Canvas Tab: Multiple "waiting for frames" messages displayed
​https://bugs.webkit.org/show_bug.cgi?id=181865
<rdar://problem/36664737>

Reviewed by Devin Rousso.

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype._recordingStarted):
(WI.CanvasContentView.prototype._recordingStopped):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-01-19  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Canvas Tab: Multiple "waiting for frames" messages displayed
+        https://bugs.webkit.org/show_bug.cgi?id=181865
+        <rdar://problem/36664737>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/CanvasContentView.js:
+        (WI.CanvasContentView.prototype._recordingStarted):
+        (WI.CanvasContentView.prototype._recordingStopped):
+
 2018-01-19  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js

@@ -264 +264 @@
         this._updateRecordNavigationItem();
 
+        if (!this.representedObject.isRecording)
+            return;
+
         if (!this._recordingProgressElement) {
             this._recordingProgressElement = this._previewContainerElement.insertAdjacentElement("beforebegin", document.createElement("div"));
@@ -298 +301 @@
 
         let {canvas, recording} = event.data;
-        if (canvas !== this.representedObject || !recording)
-            return;
-
-        this._addRecording(recording);
-
-        this._recordingProgressElement.remove();
-        this._recordingProgressElement = null;
+        if (canvas !== this.representedObject)
+            return;
+
+        if (recording)
+            this._addRecording(recording);
+
+        if (this._recordingProgressElement) {
+            this._recordingProgressElement.remove();
+            this._recordingProgressElement = null;
+        }
     }