Changeset 227408 in webkit

Timestamp:

Jan 23, 2018 1:43:46 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
​https://bugs.webkit.org/show_bug.cgi?id=181728

Reviewed by Sergio Villar Senin.

Source/WebDriver:

Due to a copy-paste error we are getting the window height using the width variable.

Fixes: imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize

imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py::testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort
imported/w3c/webdriver/tests/get_window_rect.py::test_payload
imported/w3c/webdriver/tests/set_window_rect.py::test_width_height_floats
imported/w3c/webdriver/tests/set_window_rect.py::test_height_width
imported/w3c/webdriver/tests/set_window_rect.py::test_height_width_larger_than_max
imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py::test_window_resize

• Session.cpp:

(WebDriver::Session::getToplevelBrowsingContextRect):

WebDriverTests:

Remove expectations for tests that are now passing.

• TestExpectations.json:

Location:

trunk

Files:

• Source/WebDriver/ChangeLog (modified) (1 diff)
• Source/WebDriver/Session.cpp (modified) (1 diff)
• WebDriverTests/ChangeLog (modified) (1 diff)
• WebDriverTests/TestExpectations.json (modified) (5 diffs)

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2018-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
+        https://bugs.webkit.org/show_bug.cgi?id=181728
+
+        Reviewed by Sergio Villar Senin.
+
+        Due to a copy-paste error we are getting the window height using the width variable.
+
+        Fixes: imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize
+               imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py::testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort
+               imported/w3c/webdriver/tests/get_window_rect.py::test_payload
+               imported/w3c/webdriver/tests/set_window_rect.py::test_width_height_floats
+               imported/w3c/webdriver/tests/set_window_rect.py::test_height_width
+               imported/w3c/webdriver/tests/set_window_rect.py::test_height_width_larger_than_max
+               imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py::test_window_resize
+
+        * Session.cpp:
+        (WebDriver::Session::getToplevelBrowsingContextRect):
+
 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebDriver/Session.cpp

@@ -699 +699 @@
         if (!browsingContext->getObject(ASCIILiteral("windowSize"), windowSize)
             || !windowSize->getDouble(ASCIILiteral("width"), width)
-            || !windowSize->getDouble(ASCIILiteral("height"), width)) {
+            || !windowSize->getDouble(ASCIILiteral("height"), height)) {
             completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
             return;

trunk/WebDriverTests/ChangeLog

@@ +1 @@
+2018-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
+        https://bugs.webkit.org/show_bug.cgi?id=181728
+
+        Reviewed by Sergio Villar Senin.
+
+        Remove expectations for tests that are now passing.
+
+        * TestExpectations.json:
+
 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/WebDriverTests/TestExpectations.json

@@ -12 +12 @@
     "imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py": {
         "subtests": {
-            "testChangeWindowSize": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181728"}}
-            },
             "testGetLogTypes": {
                 "expected": {"all": {"status": ["SKIP"]}}
@@ -76 +73 @@
     "imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py": {
         "subtests": {
-            "testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181734"}}
-            },
             "testShouldGetCoordinatesOfAnElementInAFrame": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181735"}}
@@ -118 +112 @@
         "expected": {"all": {"status": ["SKIP"], "bug": "webkit.org/b/174616"}}
     },
-    "imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py": {
-        "subtests": {
-            "test_window_resize": {
-                "expected": {"gtk": {"status": ["FAIL"]}}
-            }
-        }
-    },
     "imported/w3c/webdriver/tests/contexts/maximize_window.py": {
         "subtests": {
@@ -444 +431 @@
     "imported/w3c/webdriver/tests/set_window_rect.py": {
         "subtests": {
-            "test_width_height_floats": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180416"}}
-            },
             "test_fully_exit_fullscreen": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180398"}}
@@ -455 +439 @@
             "test_restore_from_maximized": {
                 "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180398"}}
-            },
-            "test_height_width": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180417"}}
-            },
-            "test_height_width_larger_than_max": {
-                "expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/180419"}}
             },
             "test_negative_x_y": {