Changeset 227419 in webkit

Timestamp:

Jan 23, 2018 9:21:08 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r227348): ASSERT_NOT_REACHED in WebKit::ServiceWorkerClientFetch::didFinish()
​https://bugs.webkit.org/show_bug.cgi?id=181956
<rdar://problem/36755492>

Patch by Youenn Fablet <​youenn@apple.com> on 2018-01-23
Reviewed by Chris Dumez.

Covered by test no longer crashing in Debug builds.
Reset m_redirectionStatus to None when starting an SW fetch.

• WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::start):
(WebKit::ServiceWorkerClientFetch::didFinish):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Storage/ServiceWorkerClientFetch.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-01-23  Youenn Fablet  <youenn@apple.com>
+
+        REGRESSION (r227348): ASSERT_NOT_REACHED in WebKit::ServiceWorkerClientFetch::didFinish()
+        https://bugs.webkit.org/show_bug.cgi?id=181956
+        <rdar://problem/36755492>
+
+        Reviewed by Chris Dumez.
+
+        Covered by test no longer crashing in Debug builds.
+        Reset m_redirectionStatus to None when starting an SW fetch.
+
+        * WebProcess/Storage/ServiceWorkerClientFetch.cpp:
+        (WebKit::ServiceWorkerClientFetch::start):
+        (WebKit::ServiceWorkerClientFetch::didFinish):
+
 2018-01-23  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp

@@ -74 +74 @@
     ASSERT(options.serviceWorkersMode != ServiceWorkersMode::None);
     m_connection->startFetch(m_loader->identifier(), options.serviceWorkerRegistrationIdentifier.value(), request, options, referrer);
+
+    m_redirectionStatus = RedirectionStatus::None;
 }
 
@@ -159 +161 @@
         return;
     case RedirectionStatus::Following:
-        m_redirectionStatus = RedirectionStatus::None;
         start();
         return;