Changeset 227616 in webkit

Timestamp:

Jan 25, 2018 11:27:32 AM (6 years ago)

Author:

eric.carlson@apple.com

Message:

REGRESSION(r227457): Release assert in updateLayout while destructing a media element
​https://bugs.webkit.org/show_bug.cgi?id=182038
<rdar://problem/36812083>

Reviewed by Jer Noble.

• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:

(TestWebKitAPI::TEST): Show/hide page so controls are always updated.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-01-25  Eric Carlson  <eric.carlson@apple.com>
+
+        REGRESSION(r227457): Release assert in updateLayout while destructing a media element
+        https://bugs.webkit.org/show_bug.cgi?id=182038
+        <rdar://problem/36812083>
+
+        Reviewed by Jer Noble.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
+        (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
+
 2018-01-24  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm

@@ -100 +100 @@
     [webView waitForMessage:@"playing"];
 
+    [webView setWindowVisible:NO];
+    [webView.get().window resignKeyWindow];
+    [webView expectHasActiveNowPlayingSession:YES];
+
     [webView setWindowVisible:YES];
     [webView.get().window makeKeyWindow];