Changeset 227649 in webkit
- Timestamp:
- Jan 25, 2018 6:42:14 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 1 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r227631 r227649 1 2018-01-25 Yusuke Suzuki <utatane.tea@gmail.com> 2 3 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html crashes 4 https://bugs.webkit.org/show_bug.cgi?id=181980 5 6 Reviewed by Ryosuke Niwa. 7 8 * TestExpectations: 9 1 10 2018-01-25 Jer Noble <jer.noble@apple.com> 2 11 -
trunk/LayoutTests/TestExpectations
r227605 r227649 1405 1405 webkit.org/b/165764 http/tests/misc/module-script-async.html [ Pass Timeout ] 1406 1406 1407 webkit.org/b/181980 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html [ Crash ]1408 1409 1407 # After rebasing WPT, we should investigate deterministic error handling, which is the updated spec. 1410 1408 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/compilation-error-1.html [ Pass Failure ] -
trunk/LayoutTests/imported/w3c/ChangeLog
r227639 r227649 1 2018-01-25 Yusuke Suzuki <utatane.tea@gmail.com> 2 3 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html crashes 4 https://bugs.webkit.org/show_bug.cgi?id=181980 5 6 Reviewed by Ryosuke Niwa. 7 8 * web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error-expected.txt: 9 * web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling-expected.txt: Added. 10 1 11 2018-01-25 Chris Dumez <cdumez@apple.com> 2 12 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error-expected.txt
r227471 r227649 1 1 2 2 PASS import() must reject when there is a parse error 3 FAIL import() must reject with the same error object for each import when there is a parse error assert_throws: It must reject the second time function "function () { throw e }" threw object "TypeError: Type error" ("TypeError") expected object "SyntaxError" ("SyntaxError") 3 PASS import() must reject with the same error object for each import when there is a parse error 4 4 PASS import() must reject when there is a bad module specifier 5 5 PASS import() must reject with different error objects for each import when there is a bad module specifier 6 6 PASS import() must reject when there is a bad module specifier in a dependency 7 FAIL import() must reject with the same error object for each import when there is a bad module specifier in a dependency assert_equals: The error objects must be equal expected object "TypeError: Type error" but got object "TypeError: Module specifier does not start with "/", "./", or "../"." 7 PASS import() must reject with the same error object for each import when there is a bad module specifier in a dependency 8 8 PASS import() must reject when there is a instantiation error 9 9 PASS import() must reject with the same error object for each import when there is a instantiation error 10 10 PASS import() must reject when there is a evaluation error 11 FAIL import() must reject with the same error object for each import when there is a evaluation error assert_unreached: Should have rejected: It must reject the firsttime Reached unreachable code11 FAIL import() must reject with the same error object for each import when there is a evaluation error assert_unreached: Should have rejected: It must reject the second time Reached unreachable code 12 12 PASS import()ing a module with an evaluation error must stop evaluation 13 13 -
trunk/Source/JavaScriptCore/ChangeLog
r227644 r227649 1 2018-01-25 Yusuke Suzuki <utatane.tea@gmail.com> 2 3 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html crashes 4 https://bugs.webkit.org/show_bug.cgi?id=181980 5 6 Reviewed by Ryosuke Niwa. 7 8 We accidentally failed to propagate errored promise in instantiate and satify phase if entry.{instantiate,satisfy} 9 promises are set. Since we just returned `entry`, it becomes succeeded promise even if the dependent fetch, instantiate, 10 and satisfy promises are failed. This patch fixes error propagation by returning `entry.instantiate` and `entry.satisfy` 11 correctly. 12 13 * builtins/ModuleLoaderPrototype.js: 14 (requestInstantiate): 15 (requestSatisfy): 16 1 17 2018-01-25 Mark Lam <mark.lam@apple.com> 2 18 -
trunk/Source/JavaScriptCore/builtins/ModuleLoaderPrototype.js
r224662 r227649 194 194 // Instantiation won't be retried. 195 195 if (entry.instantiate) 196 return entry ;196 return entry.instantiate; 197 197 entry.instantiate = instantiatePromise; 198 198 … … 230 230 var satisfyPromise = this.requestInstantiate(entry, parameters, fetcher).then((entry) => { 231 231 if (entry.satisfy) 232 return entry ;232 return entry.satisfy; 233 233 234 234 var depLoads = @newArrayWithSize(entry.dependencies.length);
Note: See TracChangeset
for help on using the changeset viewer.